tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Radim Kubacki <radim.kuba...@sun.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java StandardContext.java StandardEngine.java StandardHost.java StandardServer.java
Date Fri, 23 May 2003 09:08:37 GMT
remm@apache.org wrote:
> remm        2003/05/22 16:04:19
> 
>   Modified:    catalina/src/share/org/apache/catalina/core
>                         ContainerBase.java StandardContext.java
>                         StandardEngine.java StandardHost.java
>                         StandardServer.java
>   Log:
>   - Refactor the host deployer, session manager, webapp reloading threads
>     into one (potentially) thread at the engine level.
>   - The thread code is in StandardEngine, but can be refactored into
>     StandardServer, in case we want to be able to have one thread for the whole
>     server. The main adavantage of putting the code in container is that additional
>     threads can be associated to branches of the container tree (ex: associate
>     one thread per host, one thread for a specific context, etc ...).
>   - The container's CL (if present) will be set as the context classloader before
>     invoking the execute method, and will be restored afterwards.
>   - I couldn't come up with good neams for the new field and the thread name.
>     Can you help ?
>   - By default, the engine will have a thread with a 10s delay.
>   
>   
>   1.58      +25 -1     jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java
>   
>   Index: StandardContext.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/StandardContext.java,v
>   retrieving revision 1.57
>   retrieving revision 1.58
>   diff -u -r1.57 -r1.58
>   --- StandardContext.java	22 May 2003 18:20:03 -0000	1.57
>   +++ StandardContext.java	22 May 2003 23:04:18 -0000	1.58
>   @@ -4392,6 +4392,30 @@
>        }
>    
>    
>   +    /**
>   +     * Execute a periodic task, such as reloading, etc. This method will be
>   +     * invoked inside the classloading context of this container. Unexpected
>   +     * throwables will be caught and logged.
>   +     */
>   +    public void execute() {
>   +
>   +        if (!started)
>   +            return;
>   +
>   +        if ((getManager() != null) 
>   +            && (getManager() instanceof StandardManager)) {
>   +            ((StandardManager) getManager()).processExpires();
>   +        }
>   +
Didn't you forget to commit change to StandardManager to make 
processExpires public?

Radim

>   +        if (reloadable && (getLoader() != null)) {
>   +            if (getLoader().modified()) {
>   +                reload();
>   +            }
>   +        }
>   +
>   +    }
>   +
>   +
>        // ------------------------------------------------------ Protected Methods
>    


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message