tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ApplicationContext.java LocalStrings.properties StandardContext.java
Date Thu, 22 May 2003 20:42:56 GMT
Bill Barker wrote:
>>remm        2003/05/19 14:54:08
>>
>>  Modified:    catalina/src/share/org/apache/catalina/core
>>                        ApplicationContext.java LocalStrings.properties
>>                        StandardContext.java
>>  Log:
>>  - Swicth to the "new" mapper for request dispatching. The host mapping
> 
> is
> 
>>    copied over for cross context support (I don't see any need to
> 
> optimize this).
> 
>>    If I broke stuff, sorry. Let me know.
>>
>>  Revision  Changes    Path
>>  1.11      +78 -28
> 
> jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core/Applicat
> ionContext.java
> 
>>  Index: ApplicationContext.java
>>  >   +    /**
>>  +     * Thread local mapping data.
>>  +     */
>>  +    private ThreadLocal localMappingData = new ThreadLocal();
>>  +
>>  +
>>  +    /**
>>  +     * Thread local URI message bytes.
>>  +     */
>>  +    private ThreadLocal localUriMB = new ThreadLocal();
>>  +
>>  +
> 
> 
> Wouldn't make more sense to have these as Request notes?  Especially with
> the HTTP/1.1 Connector, the threads are short-lived but the Request gets
> reused.

I'm not sure I get the short lived argument. Anyway, the idea is that 
the request is wrapped as soon you go into a dispatcher (well, I guess 
you can retrieve the one where there's the note by using getRequest and 
getResponse), so that's why I didn't use a note. It's not too hard to 
change that.

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message