tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lu...@apache.org
Subject cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteResponse.java
Date Thu, 08 May 2003 01:24:28 GMT
luehe       2003/05/07 18:24:28

  Modified:    catalina/src/share/org/apache/coyote/tomcat5
                        CoyoteResponse.java
  Log:
  Fixed Bugtraq 4859537 ("Incorrect handling of ServletResponse.setLocale")
  
  ServletResponse.setLocale is not considered to explicitly set the
  character encoding (unlike setContentType() or
  setCharacterEncoding()). Therefore, calling setLocale() repeatedly
  with different locales should still affect the response's character
  encoding, as long as getWriter() hasn't been called yet, and the
  response hasn't been committed yet.
  
  Revision  Changes    Path
  1.3       +4 -5      jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteResponse.java
  
  Index: CoyoteResponse.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteResponse.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- CoyoteResponse.java	1 May 2003 20:47:17 -0000	1.2
  +++ CoyoteResponse.java	8 May 2003 01:24:27 -0000	1.3
  @@ -798,7 +798,6 @@
           String charset = cm.getCharset( locale );
           if ( charset != null ){
               coyoteResponse.setCharacterEncoding(charset);
  -            isCharacterEncodingSet = true;
           }
   
       }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message