tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cmanola...@yahoo.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans MBeanUtils.java
Date Tue, 22 Apr 2003 06:40:57 GMT
Amy - sorry I missed that. I tought you are going to use the engine name,
not change the object name to have an extra attribute.

A lot of stuff depends on the Engine name beeing equal with the domain.
There is no need to have this twice ( domain:type=Engine,name=domain ), 
and it would be extremely bad if the engine name and domain would be
different.

We can support multiple engines if each wih have the local part
"type=Engine" and different domains. Engine.setName() should just 
set the domain property.

I hope you didn't change to much in admin to use this - because it
certainly breaks the embed and I don't see how it could be fixed easily.



Costin


amyroh@apache.org wrote:

> amyroh      2003/04/18 02:49:39
> 
>   Modified:    catalina/src/share/org/apache/catalina/mbeans
>                         MBeanUtils.java
>   Log:
>   Add "name" attribute to engine objectname to support multiple engines in
>   the same domain.
>   
>   Revision  Changes    Path
>   1.17      +5 -5     
>  
jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java
>   
>   Index: MBeanUtils.java
>   ===================================================================
>   RCS file:
>  
/home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/mbeans/MBeanUtils.java,v
>   retrieving revision 1.16 retrieving revision 1.17
>   diff -u -r1.16 -r1.17
>   --- MBeanUtils.java 24 Mar 2003 09:18:26 -0000      1.16
>   +++ MBeanUtils.java 18 Apr 2003 09:49:39 -0000      1.17
>   @@ -1138,7 +1138,7 @@
>            throws MalformedObjectNameException {
>    
>            ObjectName name = null;
>   -        name = new ObjectName(domain + ":type=Engine");
>   +        name = new ObjectName(domain +
>   ":type=Engine,name="+engine.getName());
>            return (name);
>    
>        }



---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message