Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <3E3E9111.1010908@apache.org>
Date: Mon, 03 Feb 2003 16:56:01 +0100
From: Remy Maucherat <remm@apache.org>
Organization: ASF
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.3b) Gecko/20030114
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: [PATCH] allow tomcat5 to compile/run with JDK1.3
References: <3E3DBEFF.6090405@joedog.org> <3E3E2B82.50906@apache.org>
 <b1m2d1$l7v$1@main.gmane.org>
In-Reply-To: <b1m2d1$l7v$1@main.gmane.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Costin Manolache wrote:
> Remy Maucherat wrote:
> 
> 
>>Tim Funk wrote:
>>
>>>Tomcat5 does not compile with JDK1.3. It does with JDK1.4.
>>>
>>>There is only one line of code that prevents it from compiling with
>>>JDK1.3. org.apache.catalina.loader.WebappClassLoader depends on
>>>File.toURI() which does not exist on jdk1.3.
>>>
>>>I got around this by the performing the following:
>>>OLD CODE:
>>>  return realFile.toURI().toURL();
>>>NEW CODE
>>>  return new URL("file:" + realFile.toURL().getPath());
>>>
>>>My patch also has some spurious stuff because my text editor
>>>automatically strips all trailing whitespace from lines and converts
>>>tabs to spaces. The important stuff is the last 9 lines of the patch
>>>file.
>>
>>The patch is a bad idea. The change was made to fix RMI related problems.
>>
>>What should be done is invoke the appropriate methods through
>>reflection, catching any error (and defaulting to the old code if it
>>fails).
> 
> 
> Well, reflection is a bad idea too :-) A better solution is to use a 
> wrapper like jdkCompat ( i.e. a base class with the 1.3 implementation,
> extended with a 1.4 impl ). This class could include other 1.4 methods
> and their 1.3 equivalent, if any.

Well, I was planning to implement it as:

try {
  // do the nasty 1.4 stuff with reflection
} catch (Throwable t) {
  // do the compatible stuff
}

It's not nice but it works (and as the CL is cached, we don't care too 
much about the performance loss due to the exception).

> This would allow implementing the correct stuff, instead of failing. 

Sure.

Remy


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org