tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Costin Manolache <cmanola...@yahoo.com>
Subject Re: [PATCH] allow tomcat5 to compile/run with JDK1.3
Date Mon, 03 Feb 2003 21:59:24 GMT
Tim Funk wrote:

> To get functionality like jdkCompat (and looking at tomcat3), it looks
> like something similar to the following would need added to the existing
> jakarta-tomcat-catalina/catalina/build.xml:
> ------------------------------------------
>    <exclude name="org/apache/catalina/util/compat/JdkCompat14.java"
>             unless="jdk.1.4.present"/>
> ------------------------------------------
> Where would jdkCompat live with respect to package name? Does it belong
> in catalina? (org.apache.catalina.util.compat.ClassXXX)

I would place it in j-t-c/util, even in o.a.tomcat.util.compat ( but with a
different name than jkd11compat class in 3.3 ).

This kind of code is very common.



> Are there any other methods (wishlist) which need to be here?

We can add as we go. You can do a grep in sources for all reflection - and
see if anything else is needed there.

 
> Or am I getting ahead of myself and should I be patient and wait for
> someone with better insight to do this instead?

You seem to have good insight, please do it.

Costin 

> 
> -Tim
> 
> 
> Remy Maucherat wrote:
>> Costin Manolache wrote:
>> 
>>> Tim Funk wrote:
>>>
>>>
>>> Oh, NO. Please don't even think about it.... Commons-dbcp must do it
>>> because
>>> it is impossible to write a JDBC driver that works and compiles in
>>> both 1.3
>>> and 1.4.
>>> Reflection is fine - I would preffer using a jdkCompat-like trick and
>>> have
>>> substitute code for 1.3, but I'm fine with reflection.
>> 
>> 
>> Yes, I agree using a compat class is definitely much nicer :)
>> 
>> Remy
>>



---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message