tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Grant <Jan.Gr...@bristol.ac.uk>
Subject RE: [PATCH] forward instead of redirect for welcome files
Date Thu, 20 Feb 2003 17:59:57 GMT
On Thu, 20 Feb 2003, Shapira, Yoav wrote:

>
> Howdy,
> While I don't particularly care for this particular thread (and thus
> don't mind the patch either way), I did point want to make a couple of
> comments:
>
> >This should be a required feature.
>
> Let's be very clear on what's "required" and what's not.  Per SRV.9.10,
> "Welcome Files", and specifically to quote:
> "The web container must send the request to the first
> resource in the WAR that matches."

Yeah, goodness only knows why that got dropped between the final public
review version and the finished document.

> From the patch implementation point of view, keep in mind that the
> default servlet may be invoked too late in the request processing
> pipeline (e.g. after filters that redirect), so for the patch to consist
> solely of modifications to the DefaultServlet may be insufficient.  At
> least I think so -- I may be wrong on this point.  In tomcat 5.x, this
> will be a part of the mapper, which of course is invoked prior to any
> client servlets.  The patch I've seen contributed relies on an
> init-param to the DefaultServlet, and will probably work for most
> configurations, but we need to be careful to cover all possible cases,
> including the aforementioned filter possibility.

I'm not sure exactly what the scenario you outline here is, but anyway:
it's not been my experience that people do complex things with filters
and still rely heavily on welcome-files - you may have different
experience - partly because of the redirect behaviour.

-- 
jan grant, ILRT, University of Bristol. http://www.ilrt.bris.ac.uk/
Tel +44(0)117 9287088 Fax +44 (0)117 9287112 http://ioctl.org/jan/
Axioms speak louder than words.


---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message