Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 89848 invoked from network); 22 Jan 2003 19:24:28 -0000 Received: from exchange.sun.com (192.18.33.10) by 208.185.179.12.available.above.net with SMTP; 22 Jan 2003 19:24:28 -0000 Received: (qmail 8040 invoked by uid 97); 22 Jan 2003 19:25:46 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 8022 invoked by uid 97); 22 Jan 2003 19:25:45 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 7991 invoked by uid 98); 22 Jan 2003 19:25:43 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <3E2EEFD7.1010009@mail.more.net> Date: Wed, 22 Jan 2003 13:24:07 -0600 From: Glenn Nielsen Reply-To: glenn@mail.more.net Organization: MOREnet User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; en-US; rv:1.0.1) Gecko/20020725 Netscape/7.0 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java References: <0H9400I0ZPQHM4@mpkmail.eng.sun.com> <3E2EEF10.9050409@mail.more.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: 208.185.179.12.available.above.net 1.6.2 0/1000/N X-Spam-Rating: 208.185.179.12.available.above.net 1.6.2 0/1000/N One note, my comments below only apply to the package name for generated classes for those JSP pages compiled at runtime. What package name is used for precompiled JSP pages using JspC.java is not an issue. Glenn Glenn Nielsen wrote: > > > Kin-Man Chung wrote: > >> See below. >> >> >>> Date: Wed, 22 Jan 2003 19:03:08 +0100 >>> From: Remy Maucherat >>> Subject: Re: cvs commit: >> >> >> jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java >> >>> To: Tomcat Developers List >>> >>> Costin Manolache wrote: >>> >>>> Remy Maucherat wrote: >>>> >>>> Then why not default to the context path ? >>> >>> >>> Can you give examples ? It's very hard to determine the context path >>> from JSPC IMO. >>> >>> >>>> I think the naming conventions for the generated servlets should be >>>> settled down, documented - and treated as APIs ( i.e. no change >>>> unless absolutely needed ). >>> >>> >>> Ok, but in the meantime, we must not allow non packaged classes. >>> >>> >>>>>> When I wrote my patch, I also felt that a default package prefix was >>>>>> a good idea, but I dropped it in the end due to the package/directory >>>>>> structure mismatch. If it's really important to, you should also make >>>>>> sure the class files are generated in a directory structure that >>>>>> starts >>>>>> with "org/apache/jsp/" >>>>> >>>>> >>>>> I was wondering about that, actually, and thought this was >>>>> inconsistent. >>>> >>>> >>>> >>>> JSPC does generate the right package directory structure. I think >>>> JspServlet >>>> should do the same - if it doesn't already. >>> >>> >>> Well, I don't think we care. JspServlet generates in the workdir, and >>> uses one CL per page. So packaging is not relevant IMO. >>> OTOH, JSPC may generate the classes in /WEB-INF/classes, so we would >>> need to create the full package structure. I'd like to point out that >>> you admin precompilation example does include an extra "admin" >>> subfolder in the output directory path. >>> >>> Remy >>> >> >> >> Well, there is one case that generating the classes with the same package >> name would cause problem, and that is when you have two JSP pages with >> the >> same file name (but in different directories). Still not a problem in >> class loading, since the class files are placed in different directories, >> but you cannot debug them anymore since you cannot identify the >> classes by >> name - they have the same name. >> >> Anyone knows why it was done this way? >> > > I did some refactoring of the JasperClassLoader and the package naming > over a year ago. The code for all this in Jasper had been very convoluted > and added a great deal of overhead. The refactoring improved runtime JSP > performance by 33% and compilation by 25%. If you search the tomcat-dev > archives you can find the detailed description of what was changed and why. > > I am -1 for changing the default package name for JSP pages compiled at > runtime > from org.apache.jsp to something else until all the implication of doing > this > are thought through. > > Jean-Francois mentioned that there are SecurityManager issues related to > changing the package name. > > Glenn > > > > ---------------------------------------------------------------------- > Glenn Nielsen glenn@more.net | /* Spelin donut madder | > MOREnet System Programming | * if iz ina coment. | > Missouri Research and Education Network | */ | > ---------------------------------------------------------------------- > > > -- > To unsubscribe, e-mail: > > For additional commands, e-mail: > -- ---------------------------------------------------------------------- Glenn Nielsen glenn@more.net | /* Spelin donut madder | MOREnet System Programming | * if iz ina coment. | Missouri Research and Education Network | */ | ---------------------------------------------------------------------- -- To unsubscribe, e-mail: For additional commands, e-mail: