tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hans Bergsten <h...@gefionsoftware.com>
Subject Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper JspC.java
Date Wed, 22 Jan 2003 00:14:57 GMT
costin@apache.org wrote:
> costin      2003/01/21 15:24:51
> 
>   Modified:    jasper2/src/share/org/apache/jasper JspC.java
>   Log:
>   Use the patch submited by Hans ( at least the part related to package ).
>   
>   I modified it so that if a package is specified, it is used as prefix.
>   The second patch - I'm not sure what it does.

You mean the o.a.j.compiler.TagLibraryInfoImpl.java patch, right?
As I mentioned briefly in my last comment for the bug, it fixes a
problem with TLDs packaged in JAR files. Without this patch, you get
an NPE for this case (the problem described by bug #13212).

The code the patch removes is admittedly a mystery to me (why is a
leading slash only removed if a URLClassLoader is used? Isn't this
always the case?) and I don't remember why it failed for TLDs in
JAR files (maybe path is null?). In all my tests, however, this patch
fixes #13212 and has not caused any side-effects.

Hans

>   Revision  Changes    Path
>   1.23      +4 -4      jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java
>   
>   Index: JspC.java
>   ===================================================================
>   RCS file: /home/cvs/jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/JspC.java,v
>   retrieving revision 1.22
>   retrieving revision 1.23
>   diff -u -r1.22 -r1.23
>   --- JspC.java	21 Jan 2003 22:49:53 -0000	1.22
>   +++ JspC.java	21 Jan 2003 23:24:50 -0000	1.23
>   @@ -548,7 +548,7 @@
>                    targetClassName = null;
>                }
>                if (targetPackage != null) {
>   -                clctxt.setServletPackageName( targetPackage + "." +
>   +                clctxt.setServletPackageName( targetPackage +
>                            toPackageName(jspUri));
>                } else {
>                    clctxt.setServletPackageName( toPackageName(jspUri));
>   
>   
>   
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>
> 


-- 
Hans Bergsten                                <hans@gefionsoftware.com>
Gefion Software                       <http://www.gefionsoftware.com/>
Author of O'Reilly's "JavaServer Pages", covering JSP 1.2 and JSTL 1.0
Details at                                    <http://TheJSPBook.com/>


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message