tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 9931] - Base64 decoder chokes on a whitespace
Date Fri, 31 Jan 2003 03:29:58 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9931>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9931

Base64 decoder chokes on a whitespace

m.redington@ucl.ac.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Base64 decoder chokes on a  |Base64 decoder chokes on a
                   |whitespace: FASTER?         |whitespace



------- Additional Comments From m.redington@ucl.ac.uk  2003-01-31 03:29 -------
Here are a further two patches (one for Base64.java and one for Base64Test.java). 

These include the other patches that I've submitted. 

Changes are as follows:

Base64.java

Daniel's encode method is now fixed, and more efficient (20-50% speedup).

A newline is now appended to the end of the encoded data. The RFC implies this,
and perl behaves this way as well.

decode is now more efficient (50% speedup in my tests, with large input, but it
should be more efficient in almost all cases).

decode now silently discards non-base64 chars. This is RFC compliant behaviour,
although an error or warning in this case is encouraged by the RFC

Base64Test.java

A newline has been added to the end of the encoded data (see above changes).

The encode test is uncommented.

assertEquals bug fixed.

---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org


Mime
View raw message