tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Luehe <Jan.Lu...@Sun.COM>
Subject Re: [PATCH] Iteration tags do not synchronize scripting variables after doStartTag
Date Tue, 07 Jan 2003 00:09:30 GMT
Dimitry,

> In jasper2, I have found one interesting bug. It hapens when tag
> implements BodyTag interface and doStartTag returns EVAL_BODY_INCLUDE.
>  
> See test-case and patch attached. The patch tested under Tomcat 4.1.18.

the current synchronization behaviour your are seeing is compliant
with the spec.

Attached is the latest javadocs of
javax.servlet.jsp.tagext.VariableInfo (from the upcoming JSP 2.0),
which contains a table listing the various variable synchronization
points for the different tag handler types (see section entitled
"Synchronization Protocol").

As you will notice, there is a synchronization point for instances of
BodyTag after the invocation of doInitBody(), but not after
doStartTag(). Only instances of Tag or IterationTag have a synchronization
point after doStartTag().
This is consistent with the description of the Synchronization Protocol 
in JSP.10.5.9 ("VariableInfo") in JSP 1.2. 

Therefore, your proposed patch is invalid.


Jan



Mime
View raw message