Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 21581 invoked from network); 3 Dec 2002 16:18:12 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 3 Dec 2002 16:18:12 -0000 Received: (qmail 12874 invoked by uid 97); 3 Dec 2002 16:19:12 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 12858 invoked by uid 97); 3 Dec 2002 16:19:12 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 12844 invoked by uid 98); 3 Dec 2002 16:19:11 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <3DECD981.2020800@apache.org> Date: Tue, 03 Dec 2002 11:19:13 -0500 From: Jeanfrancois Arcand User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2) Gecko/20021126 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteResponse.java References: <20021203160402.29519.qmail@icarus.apache.org> <3DECD70A.9040001@apache.org> In-Reply-To: <3DECD70A.9040001@apache.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Remy Maucherat wrote: > jfarcand@apache.org wrote: > >> jfarcand 2002/12/03 08:04:02 >> >> Modified: coyote/src/java/org/apache/coyote Response.java >> coyote/src/java/org/apache/coyote/tomcat5 >> CoyoteResponse.java >> Log: >> As Bill's recommends, do not set a default locale in Response >> directly. > > > That seems like a bad idea. AFAIK, a default locale was set before, > and I removed it when I refactored the header handling; I think your > patch was fine. > > OTOH, calling setLocale does not do the same thing (it ends up setting > the content-language header, which may not be what you want to do). That's true. What I'm trying to do is to only set the locale attribute to confrom with the 2.4 spec. I will take a look at the spec 2.2/2.3. I'm surprised there is no local by default. -- Jeanfrancois > > > Remy > > > -- > To unsubscribe, e-mail: > > For additional commands, e-mail: > > > -- To unsubscribe, e-mail: For additional commands, e-mail: