Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 5178 invoked from network); 7 Nov 2002 20:16:49 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 7 Nov 2002 20:16:49 -0000 Received: (qmail 18612 invoked by uid 97); 7 Nov 2002 20:17:11 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 18516 invoked by uid 97); 7 Nov 2002 20:17:10 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 18494 invoked by uid 98); 7 Nov 2002 20:17:09 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-Id: <200211072016.gA7KG5718283@ha1sca-mail1.SFBay.Sun.COM> Date: Thu, 7 Nov 2002 12:16:05 -0800 (PST) From: Jan Luehe Reply-To: Jan Luehe Subject: Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/xmlparser ASCIIReader.java UCSReader.java UTF8Reader.java XMLEncodingDetector.java To: remm@apache.org Cc: tomcat-dev@jakarta.apache.org MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii Content-MD5: +UIw8Yyq7oLbnq/rsAGEOA== X-Mailer: dtmail 1.3.0 @(#)CDE Version 1.3.5 SunOS 5.7 sun4u sparc X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Remy, > luehe@apache.org wrote: > > > luehe 2002/11/06 12:14:20 > > > > Modified: jasper2/src/share/org/apache/jasper/compiler > > ErrorDispatcher.java JspReader.java JspUtil.java > > PageDataImpl.java PageInfo.java > > ParserController.java Validator.java > > jasper2/src/share/org/apache/jasper/resources > > messages.properties messages_es.properties > > messages_ja.properties > > Added: jasper2/src/share/org/apache/jasper/xmlparser > > ASCIIReader.java UCSReader.java UTF8Reader.java > > XMLEncodingDetector.java > > Log: > > First cut at I18N changes. > > > > There are problems with that patch: > > - What does it do ? > > - It seems like a big change, was it discussed before on the list ? the above changes address a number of I18N fixes to the JSP 1.2 spec, which have been discussed in the JSR-152 EG and will be addressed by the upcoming JSP 2.0 spec. The biggest change is about determining the page chatacter (source) encoding of JSP pages in XML syntax. According to the JSP 1.2 spec, the 'pageEncoding' attribute of the page directive must be used, but this is incompatible with the XML spec, which defines an encoding autodetection mechanism and XML prolog encoding attribute to specify this encoding. The JSP 2.0 spec is going to require that for JSP pages in XML syntax, the page character encoding is determined as described in section 4.3.3 and appendix F.1 of the XML specification. I realize I should have included this information in my commit message. Sorry about that. > - Trying to access the admin webapp: > java.lang.StackOverflowError > at org.apache.jasper.xmlparser.UTF8Reader.read(UTF8Reader.java:293) > at > org.apache.jasper.xmlparser.XMLEncodingDetector.load(XMLEncodingDetector.java:10 > 41) > at > org.apache.jasper.xmlparser.XMLEncodingDetector.load(XMLEncodingDetector.java:10 > 65) > at > org.apache.jasper.xmlparser.XMLEncodingDetector.load(XMLEncodingDetector.java:10 > 65) > (you get the idea) Thanks for having fixed this already! Jan -- To unsubscribe, e-mail: For additional commands, e-mail: