tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jon Scott Stevens <...@latchkey.com>
Subject Re: cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/catalina/core ContainerBase.java
Date Wed, 06 Nov 2002 00:01:58 GMT
on 2002/11/5 1:31 PM, "costin@apache.org" <costin@apache.org> wrote:

>      protected void log(String message) {
>  
> -        Logger logger = getLogger();
> -        if (logger != null)
> -            logger.log(logName() + ": " + message);
> -        else
> -            System.out.println(logName() + ": " + message);
> -
> +//         Logger logger = getLogger();
> +//         if (logger != null)
> +//             logger.log(logName() + ": " + message);
> +//         else
> +            log.info(message);
>      }

What the heck is that? There are now two methods with the same name for
logging and one goes to info and the other goes to error based on the method
signature? Where is the logic in that?

And god forbid...maybe try formatting your code properly? The spaces are off
and you put the static log at the bottom of the file???

http://java.sun.com/docs/codeconv/html/CodeConventions.doc2.html#1852

-jon


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message