tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: costin: fix reverted
Date Wed, 06 Nov 2002 18:38:19 GMT
Costin Manolache wrote:

> Remy Maucherat wrote:
>
>
> >>Can you point me to the code doing this extra processing ?
> >>
> >>I'm a bit confused:
> >>- for jsps ( with flush-in-release ) that just can't work, since the
> >>flush is already done by the jsp page.
> >>- the comment ( or the message ) in forward is probably wrong.
> >>- my bigger question is when is the response not a facade ? My
> >>understanding
> >>is that facades are used all the time, so the second part of the if will
> >>never happen
> >
> >That code was already there before the facades. I don't think it is used
> >anymore, but would leave it anyway in 4.1.x (it could be removed in 5).
>
>
> I already reverted the patch in 4.1.x - it's too dangerous for the
> stable tree.
>
> So you are saying that forward() used to do a flush, but it was
> changed when facades where added to just set the flag - to improve
> the error handling. Sounds consistent with the behavior we have now.

Yes, I think the error handling had problems before. Then I added some 
logic to the facades (bad) to fix that, and left the old code in the 
process.

>
> Could you add a little comment ( or at least remove the debug message
> that says 'flushing' ) ? The new behavior ( no real flush ) seems
> correct.

Ok, I will.

Remy


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message