tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Luehe <Jan.Lu...@sun.com>
Subject Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/xmlparser ASCIIReader.java UCSReader.java UTF8Reader.java XMLEncodingDetector.java
Date Thu, 07 Nov 2002 20:16:05 GMT
Remy,


> luehe@apache.org wrote:
> 
> > luehe       2002/11/06 12:14:20
> >
> >   Modified:    jasper2/src/share/org/apache/jasper/compiler
> >                         ErrorDispatcher.java JspReader.java JspUtil.java
> >                         PageDataImpl.java PageInfo.java
> >                         ParserController.java Validator.java
> >                jasper2/src/share/org/apache/jasper/resources
> >                         messages.properties messages_es.properties
> >                         messages_ja.properties
> >   Added:       jasper2/src/share/org/apache/jasper/xmlparser
> >                         ASCIIReader.java UCSReader.java UTF8Reader.java
> >                         XMLEncodingDetector.java
> >   Log:
> >   First cut at I18N changes.
> >   
> 
> There are problems with that patch:
> 
> - What does it do ?
> 
> - It seems like a big change, was it discussed before on the list ?


the above changes address a number of I18N fixes to the JSP 1.2
spec, which have been discussed in the JSR-152 EG and will be addressed
by the upcoming JSP 2.0 spec.

The biggest change is about determining the page chatacter (source)
encoding of JSP pages in XML syntax. According to the JSP 1.2 spec,
the 'pageEncoding' attribute of the page directive must be used, but
this is incompatible with the XML spec, which defines an encoding
autodetection mechanism and XML prolog encoding attribute to specify
this encoding.

The JSP 2.0 spec is going to require that for JSP pages in XML syntax,
the page character encoding is determined as described in section
4.3.3 and appendix F.1 of the XML specification.

I realize I should have included this information in my commit message.
Sorry about that.


> - Trying to access the admin webapp:
> java.lang.StackOverflowError
> 	at org.apache.jasper.xmlparser.UTF8Reader.read(UTF8Reader.java:293)
> 	at 
> 
org.apache.jasper.xmlparser.XMLEncodingDetector.load(XMLEncodingDetector.java:10
> 41)
> 	at 
> 
org.apache.jasper.xmlparser.XMLEncodingDetector.load(XMLEncodingDetector.java:10
> 65)
> 	at 
> 
org.apache.jasper.xmlparser.XMLEncodingDetector.load(XMLEncodingDetector.java:10
> 65)
> (you get the idea)


Thanks for having fixed this already!



Jan


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message