Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 16160 invoked from network); 4 Sep 2002 23:34:46 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 4 Sep 2002 23:34:46 -0000 Received: (qmail 16263 invoked by uid 97); 4 Sep 2002 23:35:19 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 16234 invoked by uid 97); 4 Sep 2002 23:35:18 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 16180 invoked by uid 98); 4 Sep 2002 23:35:17 -0000 X-Antivirus: nagoya (v4218 created Aug 14 2002) Message-ID: <017001c2546b$ceb57eb0$ec66a8c0@bbarkerxp> From: "Bill Barker" To: "Tomcat Developers List" References: <20020904184808.11805.qmail@icarus.apache.org> Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteResponse.java Date: Wed, 4 Sep 2002 16:35:52 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Archived: msg.XXTynWHa@scooby X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N ----- Original Message ----- From: To: Sent: Wednesday, September 04, 2002 11:48 AM Subject: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5 CoyoteResponse.java > bobh 2002/09/04 11:48:08 > > Modified: coyote/src/java/org/apache/coyote/tomcat4 > CoyoteResponse.java > coyote/src/java/org/apache/coyote/tomcat5 > CoyoteResponse.java > Log: > - I noticed that RequestDumperValve was unhappy, so I investigaged and found > that getHeaderValues(String name) was not even using the name parameter. This > fixes that. > > Revision Changes Path > 1.21 +12 -9 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteRe sponse.java > > Index: CoyoteResponse.java > =================================================================== > RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat 4/CoyoteResponse.java,v > retrieving revision 1.20 > retrieving revision 1.21 > diff -u -r1.20 -r1.21 > --- CoyoteResponse.java 4 Aug 2002 19:39:49 -0000 1.20 > +++ CoyoteResponse.java 4 Sep 2002 18:48:08 -0000 1.21 > @@ -79,6 +79,7 @@ > import java.util.Locale; > import java.util.Map; > import java.util.TimeZone; > +import java.util.Vector; > > import javax.servlet.ServletContext; > import javax.servlet.ServletException; > @@ -789,12 +790,14 @@ > public String[] getHeaderValues(String name) { > > MimeHeaders headers = coyoteResponse.getMimeHeaders(); > - int n = headers.size(); > - String[] result = new String[n]; > - for (int i = 0; i < n; i++) { > - result[i] = headers.getValue(i).toString(); > + Vector result = new Vector(); > + for (int i = 0; i < headers.size(); i++) { > + if (name.equals( headers.getName(i).toString() )) > + result.addElement( headers.getValue(i).toString() ); > } > - return result; > + String[] resultArray = new String[result.size()]; > + result.copyInto(resultArray); > + return resultArray; > > } > Headers are case-insensitive, so this still doesn't work. You're probably better off using MimeHeaders.values(String). > > > > 1.5 +12 -9 jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat5/CoyoteRe sponse.java > > Index: CoyoteResponse.java > =================================================================== > RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat 5/CoyoteResponse.java,v > retrieving revision 1.4 > retrieving revision 1.5 > diff -u -r1.4 -r1.5 > --- CoyoteResponse.java 13 Aug 2002 20:44:13 -0000 1.4 > +++ CoyoteResponse.java 4 Sep 2002 18:48:08 -0000 1.5 > @@ -79,6 +79,7 @@ > import java.util.Locale; > import java.util.Map; > import java.util.TimeZone; > +import java.util.Vector; > > import javax.servlet.ServletContext; > import javax.servlet.ServletException; > @@ -814,12 +815,14 @@ > public String[] getHeaderValues(String name) { > > MimeHeaders headers = coyoteResponse.getMimeHeaders(); > - int n = headers.size(); > - String[] result = new String[n]; > - for (int i = 0; i < n; i++) { > - result[i] = headers.getValue(i).toString(); > + Vector result = new Vector(); > + for (int i = 0; i < headers.size(); i++) { > + if (name.equals( headers.getName(i).toString() )) > + result.addElement( headers.getValue(i).toString() ); > } > - return result; > + String[] resultArray = new String[result.size()]; > + result.copyInto(resultArray); > + return resultArray; > > } > > > > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > -- To unsubscribe, e-mail: For additional commands, e-mail: