tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bob Herrmann <...@jadn.com>
Subject Re: cvs commit: jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11 Http11Processor.java
Date Wed, 18 Sep 2002 18:08:11 GMT
On Wed, 2002-09-18 at 13:58, Remy Maucherat wrote:
> Remy Maucherat wrote:
> > bobh@apache.org wrote:
> > 
> >> bobh        2002/09/18 09:44:35
> >>
> >>   Modified:    .        gump.xml
> >>                coyote/src/java/org/apache/coyote Request.java
> >>                http11/src/java/org/apache/coyote/http11
> >>                         Http11Processor.java
> >>   Log:
> >>   - This associates the socket with the Request.  This is so the
> >>   CertificatesValve.verify() can tell where (which socket) the Request
> >>   is comeing from.  Without this association, CertificatesValve.verify()
> >>   returns with no SSL Handshake.
> >>   - this change is in part based on feed back from; Vivek N. Yingxian
> >>   Wang (JSSE), Craig M., Qingqing Ouyang
> > 
> > 
> > -1 (ie, revert this).
> > 
> > The socket should already have been associated with the request, but as 
> > a note. It is available, and accessible.
> 
> Ok, I checked it, and the socket os not currently associated with the 
> request (I thought it was). OTOH, you shouldn't add a field for socket 
> in the request (native webservers don't have the notion of a Java 
> socket). Instead, use one of the notes.

Ok, 
  - change Http11Processor to use a note
  - change Request.java to it's original form
  - change the CertificatesValve.verify()

Does that sound about right?

Cheers,
-bob

> 
> Remy
> 
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>
-- 
Cheers,
-bob


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message