tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteAdapter.java
Date Mon, 30 Sep 2002 03:36:49 GMT

----- Original Message -----
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Sunday, September 29, 2002 10:31 AM
Subject: Re: cvs commit:
jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4
CoyoteAdapter.java


> nacho@apache.org wrote:
> > nacho       2002/09/29 10:07:44
> >
> >   Modified:    coyote/src/java/org/apache/coyote/tomcat4
CoyoteAdapter.java
> >   Log:
> >   Bug#12998 HTTPS gets changed to HTTP://servername:443
> >   Reported by marcus.kellermann at bentley.com
> >
> >   The processor (HTTP11 or ajp13) should set the scheme and port prior
> >   to this point, in an ajp13 connection doesnt make sense to get the
secure
> >   flag from the connector secure flag.
> >
>
> -1 for this unless you explain. The idea was to redirect to the default
> port for the protocol. Bill can probably give additional information
> (ignore the -1 if he agrees with the change).
>

Sorry, I've been out all day.

At the moment, for the HTTP11 connector, the Processor sets the ServerPort
and the Scheme correctly (even for the Servlet 2.4 spec :).  Nacho's patch
shouldn't break anything.  IMHO, low-level things like ServerPort and Scheme
belong in the Processor, and not in the Adapter.

I'll give my +1 to Nacho's patch.

> Remy
>
>
> --
> To unsubscribe, e-mail:
<mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:tomcat-dev-help@jakarta.apache.org>
>
>


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message