Return-Path: 
 <tomcat-dev-return-15918-qmlist-jakarta-archive-tomcat-dev=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org
Received: (qmail 87674 invoked from network); 8 Aug 2002 10:42:50 -0000
Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131)
  by daedalus.apache.org with SMTP; 8 Aug 2002 10:42:50 -0000
Received: (qmail 25448 invoked by uid 97); 8 Aug 2002 10:43:07 -0000
Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org
Received: (qmail 25432 invoked by uid 97); 8 Aug 2002 10:43:07 -0000
Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
List-Subscribe: <mailto:tomcat-dev-subscribe@jakarta.apache.org>
List-Help: <mailto:tomcat-dev-help@jakarta.apache.org>
List-Post: <mailto:tomcat-dev@jakarta.apache.org>
List-Id: "Tomcat Developers List" <tomcat-dev.jakarta.apache.org>
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Delivered-To: mailing list tomcat-dev@jakarta.apache.org
Received: (qmail 25420 invoked by uid 98); 8 Aug 2002 10:43:06 -0000
X-Antivirus: nagoya (v4198 created Apr 24 2002)
Message-ID: <3D524B1F.6010902@apache.org>
Date: Thu, 08 Aug 2002 12:42:39 +0200
From: Remy Maucherat <remm@apache.org>
Organization: ASF
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.1b) Gecko/20020721
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
Subject: Re: [5] commons-logging
References: <1028654035.11782.66.camel@dhcp-70-230>
 <aip0cm$372$1@main.gmane.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Costin Manolache wrote:
> Ok, it seems things are not very clear.
> 
> For tomcat5 I would like to just use commons-logging - in all log
> statements. The old <logger> will be deprecated - the interface
> will be there but the code will use commons-logging directly.
> 
> We can change the log() method to call commons-logging to speed
> up the transition, but I think the pattern should be the normal
> commons-logging one - with:
>   if( log.isDebugEnabled() ) 
>      log.debug();
> used inside the code. 
> 
> That also means the 'debug' attribute is on components will be 
> deprecated. 
> 
> The goal of this is to have a single logging API used in all the code
> ( including coyote, jk, jasper ), with consistent configuration and
> behavior.

I agree with that. It will take more time and effort, but it is cleaner. 
Since we are doing a major release and I don't really care about 
schedule anymore (only about putting something good out), I think we 
should rearchitect a bit.

> We can do less - i.e. just use commons-logging if no <logger> is 
> available.
> We can also port the Logger and Log implementations to work as 
> 'commons-logging' impl. 
> 
> Craig, Remy - and everyone else - please post your preference. 

+1 on deprecating (or worse; I'd advocate removing it, actually) debug, BTW.

Remy


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>