tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Luby <patrick.l...@sun.com>
Subject Re: [5][PATCH]commons-logging built without log4j/LogKit
Date Thu, 08 Aug 2002 05:46:49 GMT
Steve,

Thanks for the patch. I just committed it.

I assume that log4j and LogKit are required dependencies. Any chance 
that you could add those items to BUILDING.txt?

Thanks,

Patrick

Steve Downey wrote:
> The commons-logging package built by 'ant download' doesn't have support for 
> log4j or LogKit in it, unless the properties happen to be set outside of 
> jakarta-tomcat-5. This patch adds downloads for the released versions of 
> log4j and logkit.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> ? .project
> Index: build.properties.default
> ===================================================================
> RCS file: /home/cvspublic/jakarta-tomcat-5/build.properties.default,v
> retrieving revision 1.17
> diff -u -r1.17 build.properties.default
> --- build.properties.default	7 Aug 2002 14:14:03 -0000	1.17
> +++ build.properties.default	8 Aug 2002 04:54:58 -0000
> @@ -122,8 +122,17 @@
>  activation.jar=${activation.lib}/activation.jar
>  
>  # ----- Log4j -----
> -log4j.home=${base.path}/log4j
> -log4j.jar=${log4j.home}/log4j.jar
> +log4j.home=${base.path}/jakarta-log4j-1.2.6
> +log4j.lib=${log4j.home}
> +log4j.jar=${log4j.lib}/dist/lib/log4j-1.2.6.jar
> +log4j.loc=http://jakarta.apache.org/log4j/jakarta-log4j-1.2.6.tar.gz
> +
> +# ----- LogKit -----
> +logkit.home=${base.path}/LogKit-1.0.1
> +logkit.lib=${logkit.home}
> +logkit.jar=${logkit.lib}/logkit-1.0.1.jar
> +logkit.loc=http://jakarta.apache.org/builds/jakarta-avalon/release/logkit/latest/LogKit-1.0.1-bin.tar.gz
> +
>  
>  # ----- Jaxen ( required by taglibs/standard required by jasper ) -----
>  jaxen.home=${base.path}/jaxen-1.0-FCS
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/jakarta-tomcat-5/build.xml,v
> retrieving revision 1.18
> diff -u -r1.18 build.xml
> --- build.xml	7 Aug 2002 14:14:03 -0000	1.18
> +++ build.xml	8 Aug 2002 04:54:59 -0000
> @@ -492,6 +492,16 @@
>      </antcall>
>      -->
>  +    <antcall target="downloadgz">
> +      <param name="sourcefile" value="${log4j.loc}"/>
> +      <param name="destfile" value="${log4j.jar}"/>
> +    </antcall>
> +
> +    <antcall target="downloadgz">
> +      <param name="sourcefile" value="${logkit.loc}"/>
> +      <param name="destfile" value="${logkit.jar}"/>
> +    </antcall>
> +
>      <antcall target="cvsbuild">
>        <param name="location" value="${commons-logging.loc}"/>
>        <param name="subdir" value="${commons-logging.home}"/>
> 
> 
> ------------------------------------------------------------------------
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>

-- 
________________________________________________________________
Patrick Luby                     Email: patrick.luby@sun.com
Sun Microsystems                         Phone: 408-276-7471
901 San Antonio Road, USCA14-303
Palo Alto, CA 94303-4900
________________________________________________________________


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message