tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Luby <patrick.l...@sun.com>
Subject Re: [PATCH] 5.0 jakarta-tomcat-5 building
Date Wed, 31 Jul 2002 03:09:50 GMT
Bob,

I just committed your patch. As for your questions, your subject was
very clear which repository this goes in. Also, I personally prefer mime
attachments as then I don't need to hack out all of a submitter's e-mail
content.

Thanks,

Patrick

Bob Herrmann wrote:
> 
> I had a near flawless build experience building tomcat 5.0.
> 
> I only had to reverse the "digester" and "commons-logging" in build.xml
> This is because the "digester" now depends on "commons-logging"
> 
> Can someone please patch this in?  Thanks.
> 
> Cheers,
> -bob
> 
> P.S. Should patch files be attached as mime-attachments?
> 
> P.P.S. Does my subject line correctly direct this message?
>        (Is there supposed to be a [5.0] first or [PATCH] or...)
> 
> Index: build.xml
> ===================================================================
> RCS file: /home/cvspublic/jakarta-tomcat-5/build.xml,v
> retrieving revision 1.12
> diff -u -r1.12 build.xml
> --- build.xml   30 Jul 2002 22:13:49 -0000      1.12
> +++ build.xml   31 Jul 2002 02:26:50 -0000
> @@ -480,16 +480,6 @@
>        <param name="destfile" value="${commons-collections.jar}"/>
>      </antcall>
> 
> -    <antcall target="cvsbuild">
> -      <param name="location" value="${commons-digester.loc}"/>
> -      <param name="subdir" value="${commons-digester.home}"/>
> -      <param name="destfile" value="${commons-digester.jar}"/>
> -    </antcall>
> -    <copy
> -      file="${commons-digester.home}/dist/commons-digester.jar"
> -      tofile="${commons-digester.jar}"
> -    />
> -
>      <!-- we need the release to happend, in the meantime use cvs...
>      <antcall target="downloadgz">
>        <param name="sourcefile" value="${commons-logging.loc}"/>
> @@ -510,6 +500,17 @@
>        file="${commons-logging.home}/dist/commons-logging-api.jar"
>        tofile="${commons-logging-api.jar}"
>      />
> +
> +    <antcall target="cvsbuild">
> +      <param name="location" value="${commons-digester.loc}"/>
> +      <param name="subdir" value="${commons-digester.home}"/>
> +      <param name="destfile" value="${commons-digester.jar}"/>
> +    </antcall>
> +    <copy
> +      file="${commons-digester.home}/dist/commons-digester.jar"
> +      tofile="${commons-digester.jar}"
> +    />
> +
> 
>      <antcall target="downloadgz">
>        <param name="sourcefile" value="${regexp.loc}"/>
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>

-- 
_____________________________________________________________________
Patrick Luby                          Email: patrick.luby@sun.com
Sun Microsystems                              Phone: 408-276-7471
901 San Antonio Road, USCA14-303
Palo Alto, CA 94303-4900
_____________________________________________________________________

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message