tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arvind Srinivasan <arvind.sriniva...@sun.com>
Subject [PATCH] TC 4.1 - Prevent NPEs after sessions are recycled
Date Sat, 13 Jul 2002 04:24:45 GMT
The change made in v1.29 to o.a.c.session.StandardSession.java sets the
manager of a session to null *after* the session has been recycled
(another thread could pick up and start using the recycled session
before manager is set to null). Even under a light session-based
workload, this causes NPEs when the recycled session uses the manager
(to make calls like manager.getContainer() in session.setAttribute for
example).

The attached patch fixes this by not modifying the session's data
members once it has been sent to its manager for recycling.

thanks,
 Arvind

Mime
View raw message