tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bojan Smojver <bo...@rexursive.com>
Subject [BUGS: 9913, 10789] Re: cvs commit: jakarta-tomcat-connectors/jk/native2/server/apache2 mod_jk2.c
Date Fri, 19 Jul 2002 03:57:22 GMT
I've looked through Mark's excellent analysis of the problem
(http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10789) and I also played with
changing the hook order for mod_jk 1.2.0. Are you sure this actually fixes the
thing?

My experience from 1.2.0 is similar to Mark's with 2.x - the handler never gets
called because the r->handler is DIR_MAGIC_TYPE, not JK_HANDLER. So, I think
Mark's code would be the real fix for both - giving Apache a hint that the
handler is JK_HANDLER.

My original 'fix' (more like a kludge) for 1.2.0 doesn't do that. It waits for
the next round, accepts the DIR_MAGIC_TYPE call, where r->uri isn't the correct
file (i.e. it is not /some/path/index.jsp), but rather a directory
(/some/path/), which then causes havoc down the line in getServletPath(). Tomcat
3.3.x is smart and it corrects that for JSP's. I'm not sure if TC 4.x does that
at all (I have seen at least one other report related to bug 9913 with TC 4.x
where my 'fix' didn't actually fix the problem - some fix :-).

Mladen, what's your take on all this? Do you have a setup handy to verify that
the changing of hook ordering fixed the problem in mod_jk2?

Mark, does the fix in mod_jk2 work in your environment?

Bojan

PS. Sorry guys, this one is *really* bugging me...

Quoting mturk@apache.org:

> mturk       2002/07/18 08:15:00
> 
>   Modified:    jk/native2/server/apache2 mod_jk2.c
>   Log:
>   Fix the bug 10789 caused by hook order.
>   
>   Revision  Changes    Path
>   1.42      +3 -3     
> jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c
>   
>   Index: mod_jk2.c
>   ===================================================================
>   RCS file:
> /home/cvs/jakarta-tomcat-connectors/jk/native2/server/apache2/mod_jk2.c,v
>   retrieving revision 1.41
>   retrieving revision 1.42
>   diff -u -r1.41 -r1.42
>   --- mod_jk2.c	17 Jul 2002 22:43:58 -0000	1.41
>   +++ mod_jk2.c	18 Jul 2002 15:15:00 -0000	1.42
>   @@ -724,8 +724,8 @@
>        ap_hook_handler(jk2_handler, NULL, NULL, APR_HOOK_MIDDLE);
>        ap_hook_post_config(jk2_post_config,NULL,NULL,APR_HOOK_MIDDLE);
>        ap_hook_child_init(jk2_child_init,NULL,NULL,APR_HOOK_MIDDLE);
>   -    ap_hook_translate_name(jk2_translate,NULL,NULL,APR_HOOK_FIRST);
>   -    ap_hook_map_to_storage(jk2_map_to_storage, NULL, NULL,
> APR_HOOK_MIDDLE);
>   +   
> ap_hook_translate_name(jk2_translate,NULL,NULL,APR_HOOK_MIDDLE);
>   +    ap_hook_map_to_storage(jk2_map_to_storage, NULL, NULL,
> APR_HOOK_FIRST);
>    }
>    
>    module AP_MODULE_DECLARE_DATA jk2_module =
>   
>   
>   
> 
> --
> To unsubscribe, e-mail:  
> <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
> <mailto:tomcat-dev-help@jakarta.apache.org>
> 
> 

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message