Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 2080 invoked from network); 16 Jun 2002 05:09:24 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 16 Jun 2002 05:09:24 -0000 Received: (qmail 10734 invoked by uid 97); 16 Jun 2002 05:09:31 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 10713 invoked by uid 97); 16 Jun 2002 05:09:30 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 10701 invoked by uid 98); 16 Jun 2002 05:09:30 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Message-ID: <006901c214f4$b61b1880$ab7e0304@dslverizon.net> From: "Bill Barker" To: "Tomcat Developers List" References: <20020614053423.3225.qmail@icarus.apache.org> <000f01c21425$6c95d760$ab7e0304@dslverizon.net> <3D0AE614.4010002@apache.org> Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net URL.java Date: Sat, 15 Jun 2002 22:14:36 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Archived: msg.XXsmri2g@scooby X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N ----- Original Message ----- From: "Remy Maucherat" To: "Tomcat Developers List" Sent: Saturday, June 15, 2002 12:00 AM Subject: Re: cvs commit: jakarta-tomcat-connectors/util/java/org/apache/tomcat/util/net URL.java > Bill Barker wrote: > >>billbarker 2002/06/13 22:34:23 > >> > >> Modified: util/java/org/apache/tomcat/util/net URL.java > >> Log: > >> Teach URL how to parse userInfo. > >> > >> This allows URL to parse a string of the form: > >> ftp://user:pass@ftp.mycompany.com/ > >> > >> This actually doesn't fix any Tomcat problems (assuming that the string > > > > is correct to start with), and this class is only used by TC33. I just sleep > > easier if the URL is parsed correctly. > > > > > > I have no objection to applying this to o.a.c.u.URL (this is just a > > re-packaged version of that class). However, with Remy doing so many > > releases, I thought I should ask before hacking the 4.x files. ;-) Like > > Why's that ? Costin doesn't ask (and I don't complain about it) ;-) Yeah, but this doesn't actually fix anything. RFC 2396 states that the 'authority' is protocol specific (and nothing here changes 'authority'). This just allows parsing of what I think is the second most common 'authority'. > > > with 3.3 it seems that 4.x ignores the resulting (in the current code) > > MalformedURLException (from the ':'), and passes on the original URL string. > > As such (like in 3.3) it doesn't "fix" anything functionally. > > A bug was filed related to that (bug 9846). It does appear to work in 4.1.x. > I didn't try to look into why it was working though ;-) 9846 was why I looked at this at all. I haven't looked at the 4.x code, but I believe that this is one of the very few places that 3.3 and 4.x are doing the same thing. To make the URL absolute, it attempts to create an o.a.c.u.URL with the input string. When this throws a MalformedURLException, it attempts to create it as a relative URL. When this one also throws a MalformedURLException, it simply uses the input string un-modified. > > Remy > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > -- To unsubscribe, e-mail: For additional commands, e-mail: