tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn Nielsen <gl...@voyager.apg.more.net>
Subject Re: [PATCH] improved HTMLManagerServlet
Date Wed, 12 Jun 2002 23:44:11 GMT
Malcolm,

I committed your previous submission to CVS.  I'll take a look
at your changes and commit if appropriate.   Thanks! 

A few comments intermixed below:

Malcolm Edgar wrote:
> 
> Glenn Nielsen wrote:
> 
> >I installed this and took a look at it.  Looking much better. :-)
> >
> >Here are some more suggestions for improvement.
> >
> >1.  Change the title to "Tomcat Web Application Manager".
> 
> done
> 
> >2.  Move the Message: table to just below the page title.
> 
> done
> 
> >3.  Only enable the Start/Stop/Reload links based on the status of
> >     the web application.  i.e. A web application that is currently
> >     stopped can only be started or removed.
> 
> done
> 
> >4.  Include the hostname and port somewhere, perhaps below the title.
> 
> The hostname and port is in the browser's address field, do you want it
> anyway?
> 

Yes, just to make it more obvious, especially when you manage web applications
for multiple web sites.

> >5.  Add Help/Documentation for the different options.
> 
> What do you have in mind, listing help in the Message: table?
> 
Perhaps adding a Help section at the bottom, then links up above where
appropriate to anchors in the Help doc at the bottom.

> >6.  There are some features of the manager which are not available
> >     /manager/resources /manager/roles /manager/sessions.
> 

What about undeploy?

> sessions is already available in link, I will attempt resources and roles
> later.
> 

It lists the total sessions but not the breakdown you get when you use
the /manager/sessions URL.

I'm ok with resources and roles being put off for a while.

> Work has been busy, so I have been a little slow getting these mods done.
> 

Thats fine.  Thanks for your contributions.

----------------------------------------------------------------------
Glenn Nielsen             glenn@more.net | /* Spelin donut madder    |
MOREnet System Programming               |  * if iz ina coment.      |
Missouri Research and Education Network  |  */                       |
----------------------------------------------------------------------

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message