tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Barker" <wbar...@wilshire.com>
Subject Re: PROPOSAL: Consistent logging ( for 3.x, 4.x )
Date Thu, 06 Jun 2002 04:23:47 GMT

----- Original Message -----
From: <costinm@covalent.net>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Wednesday, June 05, 2002 8:21 PM
Subject: Re: PROPOSAL: Consistent logging ( for 3.x, 4.x )


> On Wed, 5 Jun 2002, Remy Maucherat wrote:
>
> > +1. It will take time, it will probably be painful to do, but it looks
like
> > the (only) way to go.
>
> Actually my point was that we can do few things now, with minimal impact
> on the release.
>

At least in 3.3 land, I'm leaning to Remy's opinion.  It's going to be
painful.  However,  I'm +1 (i.e. I'll help on the 3.3 stuff) .  As Remy
points out, TINA.

> At least changing util's Log to default to commons logging - the line
> is just commented out right now. This will make 4.1 work with only 2
> loggers instead of 3 ( well, without counting jasper ). And including
> log4j.jar in the release - another easy one ( otherwise commons-logging
> will not work very well except on 1.4 ).
>

This is where I'm starting to have problems.  It doesn't work at all in
3.3.1 as recommended on the Coyote download page (tomcat-util.jar is in
common, and commons-logging.jar is in container).  Now, commons-logging is
pretty stable, so I don't have a problem with (like in 3.3.2-dev) putting it
in common.  However, I really don't want to put log4j.jar in common since
then it would over-ride the one in WEB-INF/lib.  This is almost as bad as
putting JAXP in common.

My first thought was to move o.a.t.u.log back to jakarta-tomcat, and convert
the rest of o.a.t.u.** to commons-logging.  But this still has the same
problems.....

>
>
> After 4.1.0 - it's quite easy to change Logger to default to
> commons-logging, and same for jasper ( after all they are supposed to
> be pluggable interfaces :-). In time the code can start using
> c-l directly, but with this changes we get every log (indirectly )
> going to c-l.
>
> Then there's a small config change, i.e. removing any explicit Logger
> from server.xml ( both 3.3 and 4.1 ), and adding a sample log4j.properties
> and jdk1.4 logging.properties config.
>

Now that recycling is working again, I'm very fond of qlog.  I'd like to be
able to keep it as an option (as a plugin to commons-logging).

> What about this: after you tag the tree, I'll make the changes and see
> how it works. If you're happy, we can merge this to the release branch.
>
> ( I'll still wait for Larry, Bill and the others about 3.3 logging,
> since the switch will make all logs go to c-l in 3.3, the Log interface
> is used there heavily ).
>
> Costin
>
>
>
>
> --
> To unsubscribe, e-mail:
<mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail:
<mailto:tomcat-dev-help@jakarta.apache.org>
>


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message