Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 45571 invoked from network); 2 May 2002 04:11:47 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 2 May 2002 04:11:47 -0000 Received: (qmail 251 invoked by uid 97); 2 May 2002 04:11:53 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@nagoya.betaversion.org Received: (qmail 136 invoked by alias); 2 May 2002 04:11:52 -0000 Delivered-To: jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 122 invoked by uid 97); 2 May 2002 04:11:51 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 110 invoked by uid 98); 2 May 2002 04:11:50 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Message-ID: <009701c1f190$25d22c00$717c0304@dslverizon.net> From: "Bill Barker" To: "Tomcat Developers List" References: Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java Date: Wed, 1 May 2002 21:16:34 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 X-Archived: msg.XXEDdaT5@scooby X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N ----- Original Message ----- From: To: "Tomcat Developers List" Sent: Wednesday, May 01, 2002 8:19 PM Subject: Re: cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4 CoyoteServerSocketFactory.java > On Wed, 1 May 2002, Bill Barker wrote: > > > > Add missing "public" for getFactory. Couldn't access the method through > > > reflection without being public. > > > > > > Revision Changes Path > > > 1.2 +1 -1 > > jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/tomcat4/CoyoteSe > > rverSocketFactory.java > > > > I had thought that we had agreed to deprecate this one (in favor of some day > > being able to get PureTLS working in 4.1.x). Not that I object to Amy's > > change, but I hate to see her wasting her time on something that is going > > away. > > I thought PureTLS was working in 4.1.x ( and coyote ). At least the > networking code has all the hooks, there are just few problems with the > certs. > > Is there any additional problem ? > The problem is that o.a.c.tomcat4 doesn't play nice with others ;-). PureTLS has additional attritubutes that aren't being passed through. This can be fixed easily enough by (like TC3.3) adding a set/getAttribute & set/getProperty methods. The other problem is that the o.a.c.Request attributes aren't passed through to the ServletRequest (AFAIK, this should cause problems for JK2 as well). > ( if we're going to deprecate, it would be good to do it before the > release ) > It doesn't serve any useful purpose anymore (the actual SocketFactory is in o.a.t.u.net), but I'd deprecate rather than remove (for now), since Coyote is also used in 4.0.x. > Costin > > > -- > To unsubscribe, e-mail: > For additional commands, e-mail: > -- To unsubscribe, e-mail: For additional commands, e-mail: