Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 71141 invoked from network); 17 May 2002 01:06:32 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 17 May 2002 01:06:32 -0000 Received: (qmail 24906 invoked by uid 97); 17 May 2002 01:06:33 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 24890 invoked by uid 97); 17 May 2002 01:06:33 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 24878 invoked by uid 98); 17 May 2002 01:06:32 -0000 X-Antivirus: nagoya (v4198 created Apr 24 2002) Message-ID: <008a01c1fd3f$01c577d0$6501a8c0@apache.org> From: "Remy Maucherat" To: "Tomcat Developers List" References: <20020516165849.H41173-100000@icarus.apache.org> Subject: Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/factory DbcpDataSourceFactory.java Date: Thu, 16 May 2002 18:05:58 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > On 16 May 2002 glenn@apache.org wrote: > > > Date: 16 May 2002 21:30:22 -0000 > > From: glenn@apache.org > > Reply-To: Tomcat Developers List > > To: jakarta-tomcat-4.0-cvs@apache.org > > Subject: cvs commit: > > jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/factory > > DbcpDataSourceFactory.java > > > > glenn 02/05/16 14:30:22 > > > > Modified: catalina/src/share/org/apache/naming/factory > > DbcpDataSourceFactory.java > > Log: > > Add support for the new DBCP Features. > > > > Three new DBCP parameters were added: > > > > removeAbandoned - True or false. If true abandoned db connections > > are removed after the removeAbandonedTimout is exceeded if the dbcp > > is nearing exhaustion. > > > > removeAbandonedTimeout - Time in seconds since a connection was last > > used before it is considered abandoned. > > > > logAbandoned - True or false. If true Exception stack traces are > > created so that the source of an abandoned db connection can be logged. > > > > To avoid maintaining duplicate code for this kind of thing, what would you > think about switching Tomcat to using > org.apache.commons.dbcp.BasicDataSourceFactory instead, and made these > changes over there? That way, they would be available to non-Tomcat users > of DBCP as well. > > (Historically, I wrote DbcpDataSourceFactory first -- but it really > belonged in DBCP so it got copied to create BasicDataSourceFactory.) Big +1. Maintaining duplicated code is a bad idea, and BDS appears like a good wrapper for the PoolingDS. The change is very easy: change the value of a constant, and remove the current DBCP factory. Remy -- To unsubscribe, e-mail: For additional commands, e-mail: