tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Malcolm Edgar" <>
Subject Re: [PATCH] improved HTMLManagerServlet
Date Mon, 27 May 2002 00:39:20 GMT
Glenn Nielsen wrote:

>I have a number of comments.  First thanks for working on improving the
>1.  GC should not be user initiated, it should be left to the JVM.
>     In addition, when virtual hosting web sites, those who have permission
>     to manage applications for a particluar host may not be the
>     system admin for Tomcat.  I wouldn't want them to be able to trigger a 
>     The GC option needs to be removed.


>2.  The js which you added for onClick really isn't necessary.  The
>     HTMLManagerServlet should be usable w/o JavaScript enabled
>     in the browser. It should be removed.


>3.  The listing of memory usage isn't really needed if GC is removed.
>     It doesn't provide info that is of benefit to someone
>     who just manages web applications and is not the Tomcat sysad.
>     A Tomcat sysad would be better off using the -verbose:gc arg to
>     java when starting Tomcat so that they collect GC data which they
>     can later graph to profile the Tomcat JVM memory usage.


The memory status stuff is probably out of place here. A performance 
monitoring module could be included in the Admin application, covering mem 
status, request response time, etc.

Regards Malcolm Edgar

Get your FREE download of MSN Explorer at

View raw message