tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glenn Nielsen <gl...@voyager.apg.more.net>
Subject Re: [PATCH] improved HTMLManagerServlet
Date Fri, 31 May 2002 19:25:23 GMT
I installed this and took a look at it.  Looking much better. :-)

Here are some more suggestions for improvement.

1.  Change the title to "Tomcat Web Application Manager".

2.  Move the Message: table to just below the page title.

3.  Only enable the Start/Stop/Reload links based on the status of
     the web application.  i.e. A web application that is currently
     stopped can only be started or removed.

4.  Include the hostname and port somewhere, perhaps below the title.

5.  Add Help/Documentation for the different options.

6.  There are some features of the manager which are not available
     /manager/resources /manager/roles /manager/sessions.

Regards,

Glenn

Malcolm Edgar wrote:

> Glenn Nielsen wrote:
> 
>> I have a number of comments.  First thanks for working on improving the
>> HTMLManagerServlet.
>>
>> 1.  GC should not be user initiated, it should be left to the JVM.
>>     In addition, when virtual hosting web sites, those who have 
>> permission
>>     to manage applications for a particluar host may not be the
>>     system admin for Tomcat.  I wouldn't want them to be able to 
>> trigger a GC.
>>     The GC option needs to be removed.
> 
> 
> Done
> 
>> 2.  The js which you added for onClick really isn't necessary.  The
>>     HTMLManagerServlet should be usable w/o JavaScript enabled
>>     in the browser. It should be removed.
> 
> 
> Done
> 
>> 3.  The listing of memory usage isn't really needed if GC is removed.
>>     It doesn't provide info that is of benefit to someone
>>     who just manages web applications and is not the Tomcat sysad.
>>     A Tomcat sysad would be better off using the -verbose:gc arg to
>>     java when starting Tomcat so that they collect GC data which they
>>     can later graph to profile the Tomcat JVM memory usage.
> 
> 
> Done
> 
> The memory status stuff is probably out of place here. A performance 
> monitoring module could be included in the Admin application, covering 
> mem status, request response time, etc.
> 
> Regards Malcolm Edgar
> 
> 
> 
> _________________________________________________________________
> Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp.
> defaultservlet.directorylistingfor=Directory Listing for:
> defaultservlet.upto=Up to:
> defaultservlet.subdirectories=Subdirectories:
> defaultservlet.files=Files:
> htmlManagerServlet.appsAvailable=Running
> htmlManagerServlet.appsName=Display Name
> htmlManagerServlet.appsPath=Path
> htmlManagerServlet.appsReload=Reload
> htmlManagerServlet.appsRemove=Remove
> htmlManagerServlet.appsSessions=Sessions
> htmlManagerServlet.appsStart=Start
> htmlManagerServlet.appsStop=Stop
> htmlManagerServlet.appsTitle=Applications
> htmlManagerServlet.installButton=Install
> htmlManagerServlet.installConfig=Config URL:
> htmlManagerServlet.installPath=Path:
> htmlManagerServlet.installTitle=Install
> htmlManagerServlet.installWar=WAR URL:
> htmlManagerServlet.messageLabel=Message:
> htmlManagerServlet.serverJVMVendor=JVM Vendor
> htmlManagerServlet.serverJVMVersion=JVM Version
> htmlManagerServlet.serverOSArch=OS Arch
> htmlManagerServlet.serverOSName=OS Name
> htmlManagerServlet.serverOSVersion=OS Version
> htmlManagerServlet.serverTitle=Server
> htmlManagerServlet.serverVersion=Server Version
> htmlManagerServlet.title=Tomcat Manager
> invokerServlet.allocate=Cannot allocate servlet instance for path {0}
> invokerServlet.cannotCreate=Cannot create servlet wrapper for path {0}
> invokerServlet.deallocate=Cannot deallocate servlet instance for path {0}
> invokerServlet.invalidPath=No servlet name or class was specified in 
> path {0}
> invokerServlet.notNamed=Cannot call invoker servlet with a named dispatcher
> invokerServlet.noWrapper=Container has not called setWrapper() for this 
> servlet
> managerServlet.alreadyContext=FAIL - Application already exists at path {0}
> managerServlet.alreadyDocBase=FAIL - Directory {0} is already in use
> managerServlet.cannotInvoke=Cannot invoke manager servlet through invoker
> managerServlet.configured=OK - Installed application from context file {0}
> managerServlet.deployed=OK - Deployed application at context path {0}
> managerServlet.exception=FAIL - Encountered exception {0}
> managerServlet.installed=OK - Installed application at context path {0}
> managerServlet.invalidPath=FAIL - Invalid context path {0} was specified
> managerServlet.invalidWar=FAIL - Invalid application URL {0} was specified
> managerServlet.listed=OK - Listed applications for virtual host {0}
> managerServlet.listitem={0}:{1}:{2}:{3}
> managerServlet.noAppBase=FAIL - Cannot identify application base for 
> context path {0}
> managerServlet.noCommand=FAIL - No command was specified
> managerServlet.noContext=FAIL - No context exists for path {0}
> managerServlet.noDirectory=FAIL - Non-directory document base for path {0}
> managerServlet.noDocBase=FAIL - Cannot remove document base for path {0}
> managerServlet.noGlobal=FAIL - No global JNDI resources are available
> managerServlet.noPath=FAIL - No context path was specified
> managerServlet.noReload=FAIL - Reload not supported on WAR deployed at 
> path {0}
> managerServlet.noRename=FAIL - Cannot deploy uploaded WAR for path {0}
> managerServlet.noRole=FAIL - User does not possess role {0}
> managerServlet.noWrapper=Container has not called setWrapper() for this 
> servlet
> managerServlet.reloaded=OK - Reloaded application at context path {0}
> managerServlet.removed=OK - Removed application at context path {0}
> managerServlet.resourcesAll=OK - Listed global resources of all types
> managerServlet.resourcesType=OK - Listed global resources of type {0}
> managerServlet.rolesList=OK - Listed security roles
> managerServlet.saveFail=FAIL - Configuration save failed: {0}
> managerServlet.sessiondefaultmax=Default maximum session inactive 
> interval {0} minutes
> managerServlet.sessiontimeout={0} minutes:{1} sessions
> managerServlet.sessions=OK - Session information for application at 
> context path {0}
> managerServlet.started=OK - Started application at context path {0}
> managerServlet.startFailed=FAIL - Application at context path {0} could 
> not be started
> managerServlet.stopped=OK - Stopped application at context path {0}
> managerServlet.undeployed=OK - Undeployed application at context path {0}
> managerServlet.unknownCommand=FAIL - Unknown command {0}
> managerServlet.userDatabaseError=FAIL - Cannot resolve user database 
> reference
> managerServlet.userDatabaseMissing=FAIL - No user database is available
> webdavservlet.jaxpfailed=JAXP initialization failed
> directory.filename=Filename
> directory.lastModified=Last Modified
> directory.parent=Up To {0}
> directory.size=Size
> directory.title=Directory Listing For {0}
> directory.version=Tomcat Catalina version 4.0
> 
> 
> ------------------------------------------------------------------------
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>
> 


-- 
----------------------------------------------------------------------
Glenn Nielsen             glenn@more.net | /* Spelin donut madder    |
MOREnet System Programming               |  * if iz ina coment.      |
Missouri Research and Education Network  |  */                       |
----------------------------------------------------------------------


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message