tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Smith <msm...@xn.com.au>
Subject PATCH: DbcpDataSourceFactory
Date Fri, 10 May 2002 02:25:56 GMT
The DataSource factory wasn't setting maxIdle, and was incorrectly
setting maxActive
on the connection pool. This fixes it:

Michael


Index: DbcpDataSourceFactory.java
===================================================================
RCS file:
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/naming/factory/DbcpDataSourceFactory.java,v
retrieving revision 1.4
diff -u -r1.4 DbcpDataSourceFactory.java
--- DbcpDataSourceFactory.java  26 Dec 2001 01:22:10 -0000      1.4
+++ DbcpDataSourceFactory.java  10 May 2002 02:23:17 -0000
@@ -248,7 +248,7 @@
         }
         try {
             if (maxIdle != null)
-                connectionPool.setMaxActive(Integer.parseInt(maxIdle));
+                connectionPool.setMaxIdle(Integer.parseInt(maxIdle));
         } catch (Throwable t) {
             log("Error setting maxIdle", t);
         }

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message