tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Sandberg...@cs.stanford.edu>
Subject SSI Servlet has big problems
Date Wed, 01 May 2002 08:00:11 GMT
Hi everyone.

I ran into bug #6299 today (two server-side includes fail with buffering 
on), did some debugging, and found the cause of it.  

I have no doubt that a bunch of other bugs in bugzilla are caused by the 
same issue.  

Basically, the class and its helper classes have a pretty serious design 
flaw: they declare lots of information static ( like the servlet output 
stream ) that should not be shared between threads and/or instances of 
the servlet.

Specifically, SsiInvokerServlet.java declares SsiMediator as static. 
 SsiMediator in turn declares LOTS of things static, like the request, 
response, output stream, etc.  

This is probably causing garbled output, socket closed errors, etc. when 
multiple users are viewing .shtml files at the same time and/or when 
users are viewing output with buffered=true.

Implementing the SingleThreadedServlet interface will not help this problem.

Are the two authors still mantaining this code?  Bip Thelin? Amy Roh?

-Dan


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message