tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kin-Man Chung <Kin-Man.Ch...@Eng.Sun.COM>
Subject Re: [PATCH] Stack based "finallies" in Generator.java
Date Tue, 21 May 2002 20:57:22 GMT

> Date: Tue, 21 May 2002 09:36:42 -0400 (EDT)
> From: Denis Benoit <Denis.Benoit@fbn.ca>
> Subject: [PATCH] Stack based "finallies" in Generator.java
> X-X-Sender: benoitde@lb11300
> To: tomcat-dev@jakarta.apache.org
> Cc: Kin-Man Chung <Kin-Man.Chung@Eng.Sun.COM>
> MIME-version: 1.0
> Content-transfer-encoding: QUOTED-PRINTABLE
> 
> Hi Kin-Man,
> 
> Here is the patch as promised.
> 
> . It follows what we agreed about the "two arrays" simulating stacks;
> . It prevents generating any extra code if there is no Tags in the JSP,
>   now this case is easy to determine thanks to pageInfo.getMaxTagNesting :)
> 
> This is a first draft, I'll continue testing it, if you see something you
> don't like just give tell me so, and I'll correct it.
> 
> Thanks!
> 

Looks good!

I'd look at the generated code very carefully, to see if there is
any room for improvements.  I'd also run the watchdog tests (jsp part)
for any unexpected failures (currently there are two failures).

Thanks.


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message