Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Message-ID: <032401c1dff6$64547510$6501a8c0@apache.org>
From: "Remy Maucherat" <remm@apache.org>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
References: <20020409172350.55242.qmail@icarus.apache.org>
Subject: Re: cvs commit:
 jakarta-tomcat-connectors/http11/src/java/org/apache/coyote/http11
 Http11Processor.java
Date: Tue, 9 Apr 2002 11:43:05 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Content-Transfer-Encoding: 7bit

> costin      02/04/09 10:23:49
>
>   Modified:    http11/src/java/org/apache/coyote/http11
>                         Http11Processor.java
>   Log:
>   If host header is not set, use the local socket to set the local port
>   and hostname.
>
>   Remy - I'm not sure if this is correct, but I see no other way to
>   pass this info ( I could add a callback - but this is needed in most
>   calls ).
>
>   If there is any particular reason to keep port and localhost unset
>   I'll rollback and add the callback.
>
>   ( this used to be in the 3.3-specific code, and is needed to construct
>   redirects, etc )
>   +            //The info from socket is usually acurate
>   +            // req.setServerPort(80);

That's not good. If no host is specified with HTTP/1.1, we must default to
the protocol default (as per the HTTP spec).
The if HostMB == null implies HTTP/1.0 (with HTTP/1.1, the request
processing would be mostly over without a Host header, with a 400 response).
I've modified the patch to reflect this.

Remy


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>