Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 93068 invoked from network); 6 Apr 2002 16:59:12 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 6 Apr 2002 16:59:12 -0000 Received: (qmail 6685 invoked by uid 97); 6 Apr 2002 16:59:09 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 6669 invoked by uid 97); 6 Apr 2002 16:59:09 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 6656 invoked from network); 6 Apr 2002 16:59:08 -0000 Message-ID: <011a01c1dd8c$6cea9f40$6501a8c0@apache.org> From: "Remy Maucherat" To: "Tomcat Developers List" References: Subject: Re: CoyoteRequest: the socket Date: Sat, 6 Apr 2002 08:59:32 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MIMEOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Spam-Rating: localhost.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > On 5 Apr 2002, Eric Rescorla wrote: > > > "Remy Maucherat" writes: > > > > On Fri, 5 Apr 2002, Remy Maucherat wrote: > > > > I have big doubts the code that calls getSocket() can even work with ajp > > > > or pureTLS or other things. Probably a good idea to find where it is and > > > > call the right thing ( like getAttribute for certs, etc ). > > > > > > I'm not sure about it, but it doesn't look like client-cert would work with > > > PureTLS. > > > Hmm... I need to dig into this. Why do you think it wouldn't? > > The way it works - the connector ( or protocol handler ) creates the > socket, using plain, jsse, pureTLS. And Remy is saying that some othe > valves are calling getSocket() and use the socket/JSSE to extract info ( > I assume using JSSE specific code). > > That is going to fail if PureTLS or Ajp are used. > > But I don't think we can do anything about it - the method must be > deprecated and the code that calls it must be changed to call the right > methods ( req.getAttribute() or similar ). Yes, unfortunately, I don't see a way to make it work. > BTW, with the new protocol handler - I still haven't implemented the > ActionCode to support req.getAttribute. I need a way to pass information > up ( all existing ActionCode are passing info from connector to protocol, > and I need a way to return info ). > > After Remy reviews the o.a.t.util.handler.TcHandlerContext, I plan to > use the context as a second param in the ActionHook - and use notes to > pass/return all informations we need. I don't like this habit of allowing bad design to live forever. The Action* must go, and be replaced by the TcHandler. The Http11Protocol appears to be working fine with the new Catalina connector, with the exception of the note below. Note: I have a problem implementing getRemoteHost and getRemoteAddr. I don't think it can be done lazily. Remy -- To unsubscribe, e-mail: For additional commands, e-mail: