tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cos...@apache.org
Subject cvs commit: jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote Constants.java InputBuffer.java OutputBuffer.java
Date Mon, 08 Apr 2002 22:49:52 GMT
costin      02/04/08 15:49:52

  Modified:    coyote/src/java/org/apache/coyote Constants.java
                        InputBuffer.java OutputBuffer.java
  Log:
  Increase the number of notes per request/response.
  
  Add some comments on Output/InputBuffer.
  
  There are 2 problems:
  - they are not stateless ( the param is just a buffer, no way to extract the response, etc).
  - it would be much cleaner ( IMHO ) and consistent with the rest of the code to
  use the hook mechanism - with 1 action for input and one for output.
  ( this would also eliminate naming conflicts with the 'real' OutputBuffer and
  simplify the code )
  
  Revision  Changes    Path
  1.2       +1 -1      jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Constants.java
  
  Index: Constants.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/Constants.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- Constants.java	14 Jun 2001 01:07:56 -0000	1.1
  +++ Constants.java	8 Apr 2002 22:49:52 -0000	1.2
  @@ -83,7 +83,7 @@
       public static final Locale DEFAULT_LOCALE = new Locale(LOCALE_DEFAULT, "");
   
   
  -    public static final int MAX_NOTES = 10;
  +    public static final int MAX_NOTES = 32;
   
   
   }
  
  
  
  1.3       +4 -0      jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/InputBuffer.java
  
  Index: InputBuffer.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/InputBuffer.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- InputBuffer.java	17 Sep 2001 05:28:52 -0000	1.2
  +++ InputBuffer.java	8 Apr 2002 22:49:52 -0000	1.3
  @@ -63,6 +63,10 @@
   
   import org.apache.tomcat.util.buf.ByteChunk;
   
  +// XXX For consistency, this should be replaced with an action/hook - like all other
  +// callbacks from coyote to the protocol layer
  +
  +
   /**
    * Input buffer.
    * 
  
  
  
  1.4       +3 -0      jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/OutputBuffer.java
  
  Index: OutputBuffer.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-connectors/coyote/src/java/org/apache/coyote/OutputBuffer.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- OutputBuffer.java	17 Sep 2001 05:28:52 -0000	1.3
  +++ OutputBuffer.java	8 Apr 2002 22:49:52 -0000	1.4
  @@ -63,6 +63,9 @@
   
   import org.apache.tomcat.util.buf.ByteChunk;
   
  +// XXX For consistency, this should be replaced with an action/hook - like all other
  +// callbacks from coyote to the protocol layer
  +
   /**
    * Output buffer.
    * 
  
  
  

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message