tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remy Maucherat" <r...@apache.org>
Subject Re: CoyoteRequest: the socket
Date Fri, 05 Apr 2002 22:52:14 GMT
> 2 questions ( for Remy ):
>
> - is anyone using the getSocket() method in CoyoteRequest ? It's obvious
> this can't work for other protocols, and extracting SSL info is
> specific to the SSL impl and should be done at the protocol layer.

Some valves in the Catalina pipeline use that.

It probably should be done at the protocol layer, but I can't do that for
compatibility reasons, so I think the socket should be set as a note in the
Request object (as is suggested in the commented out code in the HTTP/1.1
protocol handler).

> - Any reason for not extending HttpBaseRequest ?

You mean HttpRequestBase in Catalina ?
This object's implementation is bad, and I wanted to deprecate it to make
that obvious. There's little code duplication overall.
There's also no ugly casts to the XXBase objects in the Catalina pipeline
(everthing uses the interfaces), so it works fine.

I'll do a CoyoteConnector2 for Catalina soon too to see how it works.
Probably tomorrow.

Remy


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message