tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remy Maucherat" <r...@apache.org>
Subject Re: cvs commit: jakarta-tomcat-jasper/jasper2/src/share/org/apache/jasper/compiler Node.java
Date Thu, 04 Apr 2002 19:20:21 GMT
> Remy,
>
> I afraid that this patch won't work, because you are initializing
> CustomTag.JspAttrs in the constructor, which is too early.
> CustomTag.JspAttrs is currently set in Validator, after tld is consulted
> to see if the tag attribute can take a request time expression;
> and if so, extracts the string between '<%=' and '%>' etc.

The patch is super easy to revert. My problem is that I don't understand
anything to the new generator design, so the patch is bad.

> Do you have a test case that causes a NPE?

Just try to run the admin webapp (and click on some tree node; there are
also some other small issues with the user admin pages).

Remy


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message