tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Carman" <ja...@carmanconsulting.com>
Subject Re: DefaultServlet problem...
Date Fri, 12 Apr 2002 11:59:45 GMT
The DefaultServlet class is performing logic which belongs (and is already
there) in the HttpServletRequest implementation.  It implements HTTP date
header parsing as follows...


                // Parsing the HTTP Date
                for (int i = 0; (date == null) && (i < formats.length); i++)
{
                    try {
                        date = formats[i].parse(headerValue);
                    } catch (ParseException e) {
                        ;
                    }
                }

The methods needing an HTTP date header should use the
HttpServletRequest.getDateHeader() method.  If it is absolutely necessary
that this logic be inside the DefaultServlet class, then it should at least
be extracted into a private helper method (called parseDateHeader or
something), rather than repeated 4 times.

----- Original Message -----
From: "James Carman" <james@carmanconsulting.com>
To: "Tomcat Developers List" <tomcat-dev@jakarta.apache.org>
Sent: Friday, April 12, 2002 7:42 AM
Subject: DefaultServlet problem...


I have downloaded the source and fixed a problem in the DefaultServlet.  How
do I submit the fix for review?



--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message