tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Luby <patrick.l...@sun.com>
Subject Re: [PATCH] for catalina.bat
Date Fri, 01 Feb 2002 23:00:22 GMT
Stephen,

You appear to be patching against a very old version of catalina.bat. Please
take a look at the most recent version that has "setlocal" in it.

Also, I noticed that you are eliminating the check for the NT when setting the
_STARTJAVA environment variable. This is necessary as Windwos 95, 98, and ME
cannot handle a "title" argument with start.

For now, I vote -1 on the patch since this patch is incompatible with the
current scripts.

Patrick

Stephen Paulsen wrote:
> 
> --- catalina.orig.bat   Fri Feb  1 13:39:47 2002
> +++ catalina.bat        Fri Feb  1 13:47:34 2002
> @@ -26,11 +26,12 @@
> 
>  rem ----- Save Environment Variables That May Change
> --------------------------
> 
> -set _CATALINA_BASE=%CATALINA_BASE%
> -set _CATALINA_HOME=%CATALINA_HOME%
> -set _CLASSPATH=%CLASSPATH%
> -set _CP=%CP%
> -
> +rem -- set _CATALINA_BASE=%CATALINA_BASE%
> +rem -- set _CATALINA_HOME=%CATALINA_HOME%
> +rem -- set _CLASSPATH=%CLASSPATH%
> +rem -- set _CP=%CP%
> +REM ----- Prevent environment changes from reaching outside this script
> -------
> +setlocal
> 
>  rem ----- Verify and Set Required Environment Variables
> -----------------------
> 
> @@ -57,7 +58,8 @@
> 
>  rem ----- Prepare Appropriate Java Execution Commands
> -------------------------
> 
> -if not "%OS%" == "Windows_NT" goto noTitle
> +REM -- Why skip title for WinNT? `start "Your Title" <command>' works fine
> on NT
> +rem -- if not "%OS%" == "Windows_NT" goto noTitle
>  set _STARTJAVA=start "Catalina" "%JAVA_HOME%\bin\java"
>  set _RUNJAVA="%JAVA_HOME%\bin\java"
>  goto gotTitle
> @@ -124,14 +126,16 @@
>  rem ----- Restore Environment Variables
> ---------------------------------------
> 
>  :cleanup
> -set CATALINA_BASE=%_CATALINA_BASE%
> -set _CATALINA_BASE=
> -set CATALINA_HOME=%_CATALINA_HOME%
> -set _CATALINA_HOME=
> -set CLASSPATH=%_CLASSPATH%
> -set _CLASSPATH=
> -set CP=%_CP%
> -set _LIBJARS=
> -set _RUNJAVA=
> -set _STARTJAVA=
> +rem -- set CATALINA_BASE=%_CATALINA_BASE%
> +rem -- set _CATALINA_BASE=
> +rem -- set CATALINA_HOME=%_CATALINA_HOME%
> +rem -- set _CATALINA_HOME=
> +rem -- set CLASSPATH=%_CLASSPATH%
> +rem -- set _CLASSPATH=
> +rem -- set CP=%_CP%
> +rem -- set _LIBJARS=
> +rem -- set _RUNJAVA=
> +rem -- set _STARTJAVA=
>  :finish
> +REM ----- End the effect of `setlocal'. Restore the previous environment.
> -----
> +endlocal
> 
> --
> To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
> For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>

-- 
_____________________________________________________________________
Patrick Luby                          Email: patrick.luby@sun.com
Sun Microsystems                              Phone: 408-276-7471
901 San Antonio Road, USCA14-303
Palo Alto, CA 94303-4900
_____________________________________________________________________

--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message