Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 48740 invoked from network); 29 Jan 2002 19:27:20 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 29 Jan 2002 19:27:20 -0000 Received: (qmail 13644 invoked by uid 97); 29 Jan 2002 19:27:15 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 13623 invoked by uid 97); 29 Jan 2002 19:27:14 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 13612 invoked from network); 29 Jan 2002 19:27:14 -0000 User-Agent: Microsoft-Entourage/10.0.0.1309 Date: Tue, 29 Jan 2002 11:27:00 -0800 Subject: [PATCH] Improving BindException error reporting From: Jon Scott Stevens To: tomcat-dev Message-ID: Mime-version: 1.0 Content-type: multipart/mixed; boundary="B_3095148421_3811618" X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N --B_3095148421_3811618 Content-type: text/plain; charset="US-ASCII" Content-transfer-encoding: 7bit Someone on the Scarab list just reported a problem with getting a BindException. It would be easier to debug the problem for the user if the exception that they sent me showed the port number that the server was trying to bind to at the time of the exception. That way, I can tell if it was the shutdown port or the running port. This is a little patch that should improve BindException error reporting. It is against the 4.0.x branch. I'm not sure that I did it 100% right so I'm submitting here in the hopes that someone (Craig? Remy?) will either approve it or fix it and apply it. When you see it, I think that you will get what I'm trying to do. Also, I'm not sure if this patch covers the shutdown port #...if it doesn't that would be another good place to apply it to as well. Thanks, -jon --B_3095148421_3811618 Content-type: application/octet-stream; name="catalina.patch" Content-disposition: attachment Content-transfer-encoding: base64 SW5kZXg6IEh0dHBDb25uZWN0b3IuamF2YQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvaG9t ZS9jdnMvamFrYXJ0YS10b21jYXQtNC4wL2NhdGFsaW5hL3NyYy9zaGFyZS9vcmcvYXBhY2hl L2NhdGFsaW5hL2Nvbm5lY3Rvci9odHRwL0h0dHBDb25uZWN0b3IuamF2YSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4yNApkaWZmIC11IC1yMS4yNCBIdHRwQ29ubmVjdG9yLmphdmEKLS0t IEh0dHBDb25uZWN0b3IuamF2YQkxMSBTZXAgMjAwMSAxNzozMzowMiAtMDAwMAkxLjI0Cisr KyBIdHRwQ29ubmVjdG9yLmphdmEJMjkgSmFuIDIwMDIgMTk6MjM6MDEgLTAwMDAKQEAgLTk0 MCwyMiArOTQwLDI1IEBACiAgICAgICAgIC8vIEFjcXVpcmUgdGhlIHNlcnZlciBzb2NrZXQg ZmFjdG9yeSBmb3IgdGhpcyBDb25uZWN0b3IKICAgICAgICAgU2VydmVyU29ja2V0RmFjdG9y eSBmYWN0b3J5ID0gZ2V0RmFjdG9yeSgpOwogCi0gICAgICAgIC8vIElmIG5vIGFkZHJlc3Mg aXMgc3BlY2lmaWVkLCBvcGVuIGEgY29ubmVjdGlvbiBvbiBhbGwgYWRkcmVzc2VzCi0gICAg ICAgIGlmIChhZGRyZXNzID09IG51bGwpIHsKLSAgICAgICAgICAgIGxvZyhzbS5nZXRTdHJp bmcoImh0dHBDb25uZWN0b3IuYWxsQWRkcmVzc2VzIikpOwotICAgICAgICAgICAgcmV0dXJu IChmYWN0b3J5LmNyZWF0ZVNvY2tldChwb3J0LCBhY2NlcHRDb3VudCkpOwotICAgICAgICB9 Ci0KLSAgICAgICAgLy8gT3BlbiBhIHNlcnZlciBzb2NrZXQgb24gdGhlIHNwZWNpZmllZCBh ZGRyZXNzCiAgICAgICAgIHRyeSB7Ci0gICAgICAgICAgICBJbmV0QWRkcmVzcyBpcyA9IElu ZXRBZGRyZXNzLmdldEJ5TmFtZShhZGRyZXNzKTsKLSAgICAgICAgICAgIGxvZyhzbS5nZXRT dHJpbmcoImh0dHBDb25uZWN0b3IuYW5BZGRyZXNzIiwgYWRkcmVzcykpOwotICAgICAgICAg ICAgcmV0dXJuIChmYWN0b3J5LmNyZWF0ZVNvY2tldChwb3J0LCBhY2NlcHRDb3VudCwgaXMp KTsKLSAgICAgICAgfSBjYXRjaCAoRXhjZXB0aW9uIGUpIHsKLSAgICAgICAgICAgIGxvZyhz bS5nZXRTdHJpbmcoImh0dHBDb25uZWN0b3Iubm9BZGRyZXNzIiwgYWRkcmVzcykpOwotICAg ICAgICAgICAgcmV0dXJuIChmYWN0b3J5LmNyZWF0ZVNvY2tldChwb3J0LCBhY2NlcHRDb3Vu dCkpOworICAgICAgICAgICAgLy8gSWYgbm8gYWRkcmVzcyBpcyBzcGVjaWZpZWQsIG9wZW4g YSBjb25uZWN0aW9uIG9uIGFsbCBhZGRyZXNzZXMKKyAgICAgICAgICAgIGlmIChhZGRyZXNz ID09IG51bGwpIHsKKyAgICAgICAgICAgICAgICBsb2coc20uZ2V0U3RyaW5nKCJodHRwQ29u bmVjdG9yLmFsbEFkZHJlc3NlcyIpKTsKKyAgICAgICAgICAgICAgICByZXR1cm4gKGZhY3Rv cnkuY3JlYXRlU29ja2V0KHBvcnQsIGFjY2VwdENvdW50KSk7CisgICAgICAgICAgICB9Cisg ICAgCisgICAgICAgICAgICAvLyBPcGVuIGEgc2VydmVyIHNvY2tldCBvbiB0aGUgc3BlY2lm aWVkIGFkZHJlc3MKKyAgICAgICAgICAgIHRyeSB7CisgICAgICAgICAgICAgICAgSW5ldEFk ZHJlc3MgaXMgPSBJbmV0QWRkcmVzcy5nZXRCeU5hbWUoYWRkcmVzcyk7CisgICAgICAgICAg ICAgICAgbG9nKHNtLmdldFN0cmluZygiaHR0cENvbm5lY3Rvci5hbkFkZHJlc3MiLCBhZGRy ZXNzKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIChmYWN0b3J5LmNyZWF0ZVNvY2tldChw b3J0LCBhY2NlcHRDb3VudCwgaXMpKTsKKyAgICAgICAgICAgIH0gY2F0Y2ggKEV4Y2VwdGlv biBlKSB7CisgICAgICAgICAgICAgICAgbG9nKHNtLmdldFN0cmluZygiaHR0cENvbm5lY3Rv ci5ub0FkZHJlc3MiLCBhZGRyZXNzKSk7CisgICAgICAgICAgICAgICAgcmV0dXJuIChmYWN0 b3J5LmNyZWF0ZVNvY2tldChwb3J0LCBhY2NlcHRDb3VudCkpOworICAgICAgICAgICAgfQor ICAgICAgICB9IGNhdGNoIChqYXZhLm5ldC5CaW5kRXhjZXB0aW9uIGJlKSB7CisgICAgICAg ICAgICB0aHJvdyBuZXcgamF2YS5uZXQuQmluZEV4Y2VwdGlvbihiZS5nZXRNZXNzYWdlKCkg KyAiIDogIiArIHBvcnQpOwogICAgICAgICB9Ci0KICAgICB9CiAKIAo= --B_3095148421_3811618 Content-Type: text/plain; charset=us-ascii -- To unsubscribe, e-mail: For additional commands, e-mail: --B_3095148421_3811618--