tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <craig...@apache.org>
Subject Re: [PATCH][4.0] ApplicationFilterChain Ctr
Date Thu, 03 Jan 2002 01:58:45 GMT


On Mon, 31 Dec 2001, Christopher K. St. John wrote:

> Date: Mon, 31 Dec 2001 15:59:51 -0600
> From: Christopher K. St. John <cks@distributopia.com>
> Reply-To: Tomcat Developers List <tomcat-dev@jakarta.apache.org>
> To: tomcat-dev@jakarta.apache.org
> Subject: [PATCH][4.0] ApplicationFilterChain Ctr
>
>
>  ApplicationFilterChain has a constructor that doesn't do
> anything useful. It's call to super() is a bit confusing,
> since it leads to the assumption that FilterChain is a
> class. Other interface implementations in Catalina don't
> bother with placeholder constructors, this patch removes
> the one in ApplicationFilterChain.
>

Christopher,

I'm going to look at your suggestions for ApplicationFilterChain and
StandardPipeline, but would like to wait a few days before committing
anything -- I'm almost at a code freeze on an (internal) project using
Tomcat, and would like to not do anything stupid at this point.  I've
committed the typo-fixes (and I agree with you that they make life
better).

>  I've been posting patches as I come across bits of code
> and documentation that look iffy. None of them have been
> showstoppers and none of them are the kind of thing normal
> people can work up much enthusiam about. But crappy little
> cleanup patches really do help in the long run. Especially
> documentation cleanup. I was under the impression that
> stuff like this didn't go through the normal code-change
> voting process, it just got picked up (or not) by a
> committer and merged in. Is that correct? Would it be more
> appropriate to submit bug reports?
>

You're correct about the process.  I guess that I'd prefer to see stuff
like this sent through the bug tracking system
(http://nagoya.apache.org/bugzilla) just to make sure it doesn't get lost
in the volume of messages on the mailing list.  You can add the patch file
as an attachment.

But I'll still try to pay attention to them either way ... :-)

>
> --
> Christopher St. John cks@distributopia.com
> DistribuTopia http://www.distributopia.com
>

Craig


--
To unsubscribe, e-mail:   <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
For additional commands, e-mail: <mailto:tomcat-dev-help@jakarta.apache.org>


Mime
View raw message