Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@apache.org Received: (qmail 83699 invoked from network); 9 Nov 2001 01:19:03 -0000 Received: from unknown (HELO nagoya.betaversion.org) (192.18.49.131) by daedalus.apache.org with SMTP; 9 Nov 2001 01:19:03 -0000 Received: (qmail 29573 invoked by uid 97); 8 Nov 2001 19:57:13 -0000 Delivered-To: qmlist-jakarta-archive-tomcat-dev@jakarta.apache.org Received: (qmail 29551 invoked by uid 97); 8 Nov 2001 19:57:13 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Tomcat Developers List" Reply-To: "Tomcat Developers List" Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 29536 invoked from network); 8 Nov 2001 19:57:12 -0000 Message-ID: <018c01c16890$4cb90de0$6a16a643@snvl1.sfba.home.com> From: "Remy Maucherat" To: "Tomcat Developers List" References: <3BEAE120.6030707@tektix.com> Subject: Re: Log Tomcat access to a database Date: Thu, 8 Nov 2001 12:02:31 -0800 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2600.0000 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N > Dear all > > I wrote a simple database logger, most of it based on the regular > AccessLogValve that comes with tomcat. Could you please check the code > and make suggestions for improvement? The code looks good. The only problem I can think is that it probably needs syncing (two simultaneous requests could fight over the prepared statement, which would result in corrupted log entries). I'll fix the tabs, set the header, and commit it, and we can improve it then. Thanks for the contribution :) > Could it be included in the standard tomcat distribution? Yes, that looks useful, so we can do that. Remy -- To unsubscribe, e-mail: For additional commands, e-mail: