Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 91080 invoked by uid 500); 26 Oct 2001 19:58:37 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: tomcat-dev@jakarta.apache.org Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 91071 invoked from network); 26 Oct 2001 19:58:37 -0000 Message-ID: <3BD9A876.8040404@collab.net> Date: Fri, 26 Oct 2001 11:16:22 -0700 From: Jason Brittain Organization: CollabNet User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5) Gecko/20011012 X-Accept-Language: en-us MIME-Version: 1.0 To: tomcat-dev@jakarta.apache.org Subject: Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves AccessLogValve.java References: <20011023230810.82985.qmail@icarus.apache.org> <3BD7437E.3050101@collab.net> <00f401c15d8d$136124f0$6a16a643@snvl1.sfba.home.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Remy Maucherat wrote: >>Since the bug was likely originally my fault, I felt compelled to >>report to you about this missing hunk. :) > > I didn't backport this since I didn't think it was useful. It should just > save a few operations if there's a race there, I think. > Maybe it would be safer to add it too. > > Remy Yeah, I was thinking it would be a good idea for consistency (future patching across more than one branch, etc.). Thanks for fixing it.. -- Jason Brittain CollabNet http://www.collab.net