Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: tomcat-dev@jakarta.apache.org
Message-ID: <00f401c15d8d$136124f0$6a16a643@snvl1.sfba.home.com>
From: "Remy Maucherat" <rmaucher1@home.com>
To: <tomcat-dev@jakarta.apache.org>
References: <20011023230810.82985.qmail@icarus.apache.org>
 <3BD7437E.3050101@collab.net>
Subject: Re: cvs commit:
 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves
 AccessLogValve.java
Date: Thu, 25 Oct 2001 12:41:43 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit

> Hi Remy!
>
> Cool bugfix, but you forgot to backport a piece of it:
>
>   @@ -604,11 +612,14 @@
>                 // If the date has changed, switch log files
>                 if (!dateStamp.equals(tsDate)) {
>                     synchronized (this) {
>    -                    close();
>    -                    dateStamp = tsDate;
>    -                    open();
>    +                    if (!dateStamp.equals(tsDate)) {
>    +                        close();
>    +                        dateStamp = tsDate;
>    +                        open();
>    +                    }
>                     }
>                 }
>    +
>             }
>
>             // Log this message
>
> Since the bug was likely originally my fault, I felt compelled to
> report to you about this missing hunk.  :)

I didn't backport this since I didn't think it was useful. It should just
save a few operations if there's a race there, I think.
Maybe it would be safer to add it too.

Remy