tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remy Maucherat" <rmauch...@home.com>
Subject Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves AccessLogValve.java
Date Thu, 25 Oct 2001 19:41:43 GMT
> Hi Remy!
>
> Cool bugfix, but you forgot to backport a piece of it:
>
>   @@ -604,11 +612,14 @@
>                 // If the date has changed, switch log files
>                 if (!dateStamp.equals(tsDate)) {
>                     synchronized (this) {
>    -                    close();
>    -                    dateStamp = tsDate;
>    -                    open();
>    +                    if (!dateStamp.equals(tsDate)) {
>    +                        close();
>    +                        dateStamp = tsDate;
>    +                        open();
>    +                    }
>                     }
>                 }
>    +
>             }
>
>             // Log this message
>
> Since the bug was likely originally my fault, I felt compelled to
> report to you about this missing hunk.  :)

I didn't backport this since I didn't think it was useful. It should just
save a few operations if there's a race there, I think.
Maybe it would be safer to add it too.

Remy


Mime
View raw message