Return-Path: Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org Received: (qmail 50635 invoked by uid 500); 7 Sep 2001 18:33:31 -0000 Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: tomcat-dev@jakarta.apache.org Delivered-To: mailing list tomcat-dev@jakarta.apache.org Received: (qmail 50626 invoked from network); 7 Sep 2001 18:33:31 -0000 From: "Peter Romianowski" To: Subject: RE: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java Date: Fri, 7 Sep 2001 20:35:46 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) In-Reply-To: <00a001c137c1$28de5600$82deb018@intalio.com> X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4522.1200 Importance: Normal X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N yes, the solution looks like a great deal in both, performance and stability, enven though i found out that synchronizing the ResourceEntry entry is enough. (at least it does not cause my good old error :-) i think the concurrent access to the ResourceEntry-object is the point which leads to the error. (but i'm not sure if changing synchronized (this) to synchronized (entry) will have any signficant positive impact on the performance...) keep on the good work! pero -----Original Message----- From: Remy Maucherat [mailto:remm@apache.org] Sent: Friday, September 07, 2001 7:19 PM To: tomcat-dev@jakarta.apache.org Subject: Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/loader WebappClassLoader.java > no, Peter tells you that it is WORKING! Yep. Way COOL ! It's great, because it would have been bad to sync anywhere on the critical path (since findResourceInternal is called quite often). The updated code doesn't hurt performance in any significant way (it strenghtens a bit one sync, and makes two more HashMaps lookups during the class loading), so that's great news. Remy