Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: tomcat-dev@jakarta.apache.org
Message-ID: <D84B43C5F94DD511877400609457497C01CA19@css4.cs>
From: GOMEZ Henri <hgomez@slib.fr>
To: tomcat-dev@jakarta.apache.org
Subject: RE: [J-T-C] Apache 2.0 code review required
Date: Sat, 15 Sep 2001 01:07:57 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"

>> Hi to all,
>> 
>> I've just commited updated code for Apache 1.3/2.0
>>  
>> I will need a serious code review on Apache 2.0 part
>> and particulary the ws_read() which was grabbed from
>> 1.3 and works (at least on Apache 2.0.24) but may 
>> be optimized...
><snip, snip>
>> ws_write() could need also a serious cleanup and see if the 
>> CHUNK_SIZE of 4k is still valid.
>> 
>> /* Works with 4096, fails with 8192 */
>> #define CHUNK_SIZE 4096
>
>Should be no need for this chunking.  Just pass it all to 
>ap_rwrite.  If that doesn't work, then we have problem on our end
>that we need to fix.
>
>Since you have a "common" infrastructure via callbacks, I don't think
>you can take advantage of a lot of the new features in Apache 2.0.

Yo another Apache 2.0 gurus digging Tomcat list :)

What new features in Apache 2.0 could be usefull for us in mod_jk ?

The common infrastructure allow us to have it on many webservers
and if one platform could be optimized, we could still make 
adaptations :))

I'm waiting for advices....