From tomcat-dev-return-26871-apmail-jakarta-tomcat-dev-archive=jakarta.apache.org@jakarta.apache.org Tue Sep 04 21:05:00 2001
Return-Path: <tomcat-dev-return-26871-apmail-jakarta-tomcat-dev-archive=jakarta.apache.org@jakarta.apache.org>
Delivered-To: apmail-jakarta-tomcat-dev-archive@jakarta.apache.org
Received: (qmail 38043 invoked by uid 500); 4 Sep 2001 21:04:59 -0000
Mailing-List: contact tomcat-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:tomcat-dev-help@jakarta.apache.org>
list-unsubscribe: <mailto:tomcat-dev-unsubscribe@jakarta.apache.org>
list-post: <mailto:tomcat-dev@jakarta.apache.org>
Reply-To: tomcat-dev@jakarta.apache.org
Delivered-To: mailing list tomcat-dev@jakarta.apache.org
Received: (qmail 38026 invoked by uid 500); 4 Sep 2001 21:04:59 -0000
Delivered-To: apmail-jakarta-tomcat-4.0-cvs@apache.org
Date: 4 Sep 2001 21:02:35 -0000
Message-ID: <20010904210235.67573.qmail@icarus.apache.org>
From: craigmcc@apache.org
To: jakarta-tomcat-4.0-cvs@apache.org
Subject: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util CookieTools.java
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

craigmcc    01/09/04 14:02:35

  Modified:    catalina/src/share/org/apache/catalina/util CookieTools.java
  Log:
  Call URLEncode on cookie names and values, to correspond with the fact
  that we call URLDecode when *reading* the returned values.
  
  PR: Bugzilla #3232
  Submitted by:	scott@scottbender.net
  
  Revision  Changes    Path
  1.4       +7 -6      jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/CookieTools.java
  
  Index: CookieTools.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/CookieTools.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- CookieTools.java	2001/07/22 20:25:13	1.3
  +++ CookieTools.java	2001/09/04 21:02:35	1.4
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/CookieTools.java,v 1.3 2001/07/22 20:25:13 pier Exp $
  - * $Revision: 1.3 $
  - * $Date: 2001/07/22 20:25:13 $
  + * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/CookieTools.java,v 1.4 2001/09/04 21:02:35 craigmcc Exp $
  + * $Revision: 1.4 $
  + * $Date: 2001/09/04 21:02:35 $
    *
    * ====================================================================
    *
  @@ -63,6 +63,7 @@
   
   
   package org.apache.catalina.util;
  +import java.net.URLEncoder;
   import java.text.*;
   import java.util.*;
   
  @@ -107,7 +108,7 @@
   
           // this part is the same for all cookies
   
  -        buf.append(cookie.getName());
  +        buf.append(URLEncoder.encode(cookie.getName()));
           buf.append("=");
           maybeQuote(version, buf, cookie.getValue());
   
  @@ -165,10 +166,10 @@
                                       String value)
       {
           if (version == 0 || isToken (value))
  -          buf.append (value);
  +          buf.append (URLEncoder.encode(value));
           else {
               buf.append ('"');
  -            buf.append (value);
  +            buf.append (URLEncoder.encode(value));
               buf.append ('"');
           }
       }